After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 137717 - Gtk+ filechooser should allow drag-n-drop of files in the desktop trash and in the trash window
Gtk+ filechooser should allow drag-n-drop of files in the desktop trash and i...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
unspecified
Other Linux
: Normal normal
: Need diagnosis
Assigned To: Federico Mena Quintero
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2004-03-19 19:56 UTC by Vincent Noel
Modified: 2008-05-25 14:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add GDK_ACTION_MOVE to allow move and trash (which is a move) (485 bytes, patch)
2008-05-09 07:46 UTC, Jan Arne Petersen
committed Details | Review

Description Vincent Noel 2004-03-19 19:56:39 UTC
Currently you can drag-n-drop files from the new filechooser to the
nautilus desktop. However, if you try to drop a file in the trash (say for
example you noticed a "core" file in your $HOME) the file gets copied on
the desktop anyway.
Opening the trash in a nautilus window and dropping a file from the
fileselector into it doesnt work either, but there it's worse as the
dropping is not allowed.

this is with gtk+ 2.4.0
Comment 1 Owen Taylor 2004-03-19 20:08:40 UTC
This is a nautilus issue, right?
Comment 2 Federico Mena Quintero 2004-03-22 16:32:58 UTC
I'm working on this (trying to figure out if it's a Nautilus bug or a
GtkFileChooser one).
Comment 3 Alexander Larsson 2004-03-24 07:56:56 UTC
Its probably a nautilus bug, since the drop side is supposed to do the operation.
Comment 4 Elijah Newren 2004-06-19 18:44:44 UTC
Mass changing gtk+ bugs with target milestone of 2.4.2 to target 2.4.4, as
Matthias said he was trying to do himself on IRC and was asking for help with. 
If you see this message, it means I was successful at fixing the borken-ness in
bugzilla :)  Sorry for the spam; just query on this message and delete all
emails you get with this message, since there will probably be a lot.
Comment 5 Sebastien Bacher 2005-05-05 14:13:32 UTC
same issue with the trashapplet described here: https://bugzilla.ubuntu.com/8002
Comment 6 Jan Arne Petersen 2008-05-09 07:46:24 UTC
Created attachment 110622 [details] [review]
Add GDK_ACTION_MOVE to allow move and trash (which is a move)
Comment 7 Matthias Clasen 2008-05-25 04:19:11 UTC
This seems to fix things only partially, though.

With the patch, dropping to the trash applet works, but the file chooser (at least with the unix backend) does not update the display, I have to force a reload to make the deleted file disappear.

Dropping on the nautilus trash icon does not work unless I force the move action by pressing Shift.
Comment 8 Jan Arne Petersen 2008-05-25 14:03:22 UTC
First one could be something like bug 529966.

Second one is a nautilus bug. In nautilus_icon_container_get_drop_action (libnautilus-private/nautilus-icon-dnd.c) there should be some target checks in the NAUTILUS_ICON_DND_URI_LIST case as in the NAUTILUS_ICON_DND_GNOME_ICON_LIST case.
Comment 9 Jan Arne Petersen 2008-05-25 14:24:54 UTC
2008-05-25  Jan Arne Petersen  <jpetersen@jpetersen.org>

	* gtk/gtkfilechooserdefault.c: (create_file_list): Add GDK_ACTION_MOVE
	to the drag actions to allow trash (#137717).