After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 137520 - Visual hint during directory load needed
Visual hint during directory load needed
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
2.4.x
Other All
: High normal
: ---
Assigned To: Federico Mena Quintero
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2004-03-17 18:14 UTC by Morten Welinder
Modified: 2011-02-04 16:16 UTC
See Also:
GNOME target: ---
GNOME version: 2.3/2.4

Attachments
Patch that adds a "finished-loading" signal to GtkFileFolder (14.08 KB, patch)
2004-03-19 21:03 UTC, Federico Mena Quintero 		none Details | Review
Patch to implement finished-loading in GtkFileSystemGnomeVFS (2.28 KB, patch)
2004-03-19 21:15 UTC, Federico Mena Quintero 		none Details | Review

Description Morten Welinder 2004-03-17 18:14:54 UTC 
I would like to see some kind of visual hint after double-clicking a
directory causing it to be loaded.

Several times I have found myself wondering if I was too slow (== did two
single clicks) and re-double-clicked, only to end up selecting whatever
is later shown at that screen location.

Yes, NFS is that slow.
Comment 1 Federico Mena Quintero 2004-03-19 17:30:13 UTC 
I'm working on this.
Comment 2 Morten Welinder 2004-03-19 18:44:46 UTC 
This is a brutal way of doing things, but it works pretty well.


--- gtkfilechooserdefault.c.~1.159.~	Wed Mar 17 15:54:16 2004
+++ gtkfilechooserdefault.c	Fri Mar 19 13:40:28 2004
@@ -3608,6 +3608,10 @@
 {
   if (impl->browse_files_model)
     {
+      gdk_window_clear (gtk_tree_view_get_bin_window (GTK_TREE_VIEW
(impl->browse_files_tree_view)));
+      while (gtk_events_pending ())
+	gtk_main_iteration_do (FALSE);
+
       g_object_unref (impl->browse_files_model);
       g_object_unref (impl->sort_model);
     }
Comment 3 Federico Mena Quintero 2004-03-19 19:45:33 UTC 
No, that's on crack.  I just fixed it on CVS.
Comment 4 Federico Mena Quintero 2004-03-19 21:01:57 UTC 
Reopening and attaching the patch; this should not go in until after
2.4.1.
Comment 5 Federico Mena Quintero 2004-03-19 21:03:30 UTC 
Created attachment 25815 [details] [review]
Patch that adds a "finished-loading" signal to GtkFileFolder
Comment 6 Federico Mena Quintero 2004-03-19 21:14:00 UTC 
Also attaching an untested patch to add support for this to
GtkFileSystemGnomeVFS.  It builds; I don't know if it works.
Comment 7 Federico Mena Quintero 2004-03-19 21:15:07 UTC 
Created attachment 25816 [details] [review]
Patch to implement finished-loading in GtkFileSystemGnomeVFS
Comment 8 Federico Mena Quintero 2004-03-29 20:43:16 UTC 
Committed both patches.