After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 137284 - Mismatched album covers
Mismatched album covers
Status: RESOLVED FIXED
Product: muine
Classification: Other
Component: general
0.8.6 or older
Other All
: Normal normal
: ---
Assigned To: Muine Maintainers
Muine Maintainers
: 137286 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-03-15 20:06 UTC by spark
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch that tries to find the best match, not just the first (2.19 KB, patch)
2004-03-16 20:11 UTC, bugzilla 		none Details | Review

Description spark 2004-03-15 20:06:10 UTC 
> Orbital - Orbital
> 
> Should show:
>
http://www.amazon.com/exec/obidos/tg/detail/-/B00004T6UY/qid=1079310100/sr=8-3/ref=pd_ka_3/103-7748037-8091058?v=glance&s=music&n=507846
> (yellow cover)
> 
> Actually shows:
>
http://www.amazon.com/exec/obidos/tg/detail/-/B00004T6UZ/qid=1079310100/sr=8-2/ref=pd_ka_2/103-7748037-8091058?v=glance&s=music&n=507846
> (brown cover for "Orbital - Orbital 2")
> 
> Blur - Blur
> 
> Should show:
>
http://www.amazon.com/exec/obidos/ASIN/B000000WDA/qid=1079310224/sr=2-3/ref=sr_2_3/103-7748037-8091058
> (yellowish cover)
> 
> Actually shows:
>
http://www.amazon.com/exec/obidos/ASIN/B00005176F/qid=1079310224/sr=2-2/ref=sr_2_2/103-7748037-8091058
> (faces cover for "Blur - The Best of Blur")


id3v1 tag info for Orbital - Satan.mp3:
Title  : Satan                           Artist: Orbital
Album  : Orbital                         Year:     , Genre: Unknown (255)
Comment:

id3v1 tag info for Blur - Song 2.mp3:
Title  : Song 2                          Artist: Blur
Album  : Blur                            Year:     , Genre: Unknown (255)
Comment:                                 Track: 2
id3v2 tag info for Blur - Song 2.mp3:
TIT2 (Title/songname/content description): Song 2
TPE1 (Lead performer(s)/Soloist(s)): Blur
TALB (Album/Movie/Show title): Blur
TRCK (Track number/Position in set): 02
TLEN (Length): 121000
Comment 1 bugzilla 2004-03-15 20:44:08 UTC 
*** Bug 137286 has been marked as a duplicate of this bug. ***
Comment 2 bugzilla 2004-03-15 20:46:06 UTC 
Muine stops checking for images as soon as it has found a title/artist
match. This is less than perfect in the following cases:

- The first match does not have an image, but subsequent matches do. In
this case muine displays no cover when it could conceivably get one
(Example "Detunized Gravity" by "De Phazz")
- The first match (Heuristically) is not the right album, and further
result iteration *would* find the right album

uine should search for the best match, where best is defined as:

- Greatest % match that has an image, and % is greater than the
defined threshold - probably being intelligent to stop if it gets a
100% match (Both ways) with an image.
Comment 3 bugzilla 2004-03-16 20:11:32 UTC 
Created attachment 25700 [details] [review]
Patch that tries to find the best match, not just the first
Comment 4 Jorn Baayen 2004-04-04 16:20:20 UTC 
Committed, including a small optimization and 1x1 image checking.