After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 137279 - [patch] dispose/finalize functions for gst core elements
[patch] dispose/finalize functions for gst core elements
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal minor
: 0.8.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-03-15 19:10 UTC by Tim-Philipp Müller
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (10.28 KB, patch)
2004-03-15 19:11 UTC, Tim-Philipp Müller 		none Details | Review

Description Tim-Philipp Müller 2004-03-15 19:10:24 UTC 
Hi, 
 
various elements don't clean up properly after themselves, others do 
clean up, but don't take into account that GObject::dispose may be called 
multiple times (as opposed to ::finalize). 
 
Attached a patch that adds/fixes dispose/finalize functions where 
appropriate (and also does various other minor cleanups). 
 
Most of the code is not tested due to the somewhat specialised nature of 
most of the affected elements. 
 
Cheers 
-Tim
Comment 1 Tim-Philipp Müller 2004-03-15 19:11:09 UTC 
Created attachment 25674 [details] [review]
proposed patch
Comment 2 David Schleef 2004-03-17 23:28:04 UTC 
It passes the "makes sense" test.  It should be applied once someone
does a careful review of each change, since we'd be applying it
blindly to a stable release.
Comment 3 Benjamin Otte (Company) 2004-03-21 03:23:13 UTC 
reviewed and applied