After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 137108 - Selecting "Filesystem" in the File Selection dialog box crashes
Selecting "Filesystem" in the File Selection dialog box crashes
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
unspecified
Other other
: High major
: ---
Assigned To: gtk-bugs
gtk-bugs
: 137123 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-03-13 21:35 UTC by test
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description test 2004-03-13 21:35:36 UTC
Distribution: Gentoo Base System version 1.4.3.13p1
Package: gtk+
Severity: normal
Version: GNOME2.5.91 unspecified
Gnome-Distributor: GARNOME
Synopsis: Selecting "Filesystem" in the File Selection dialog box crashes
Bugzilla-Product: gtk+
Bugzilla-Component: GtkFileSel
Bugzilla-Version: unspecified
BugBuddy-GnomeVersion: 2.0 (2.5.91)
Description:
Description of the crash:
Everytime I try to select the root "Filesystem" shortcut in the File
Selection dialog box, it crashes.

Steps to reproduce the crash:
1. Create new launcher on desktop
2. Select browse
3. Choose "Filesystem"

Expected Results:
Crash

How often does this happen?
Every time

Additional Information:
I'm using garnome for 2.5.91


Debugging Information:

Backtrace was generated from
'/home/test/garnome/bin/gnome-desktop-item-edit'

Using host libthread_db library "/lib/libthread_db.so.1".
0x40bde9c8 in waitpid () from /lib/libpthread.so.0
  • #0 waitpid
    from /lib/libpthread.so.0
  • #1 __JCR_LIST__
    from /home/test/garnome/lib/libgnomeui-2.so.0
  • #2 libgnomeui_segv_handle
    at gnome-ui-init.c line 741
  • #3 __pthread_clock_settime
    from /lib/libpthread.so.0
  • #4 <signal handler called>
  • #5 error_dialog
    at gtkfilechooserdefault.c line 608
  • #6 error_changing_folder_dialog
    at gtkfilechooserdefault.c line 665
  • #7 change_folder_and_display_error
    at gtkfilechooserdefault.c line 683
  • #8 shortcuts_activate_volume
    at gtkfilechooserdefault.c line 3727
  • #9 shortcuts_activate_item
    at gtkfilechooserdefault.c line 3762
  • #10 shortcuts_row_activated_cb
    at gtkfilechooserdefault.c line 3798
  • #11 _gtk_marshal_VOID__BOXED_OBJECT
    at gtkmarshalers.c line 1104
  • #12 g_closure_invoke
    at gclosure.c line 437
  • #13 signal_emit_unlocked_R
    at gsignal.c line 2436
  • #14 g_signal_emit_valist
    at gsignal.c line 2195
  • #15 g_signal_emit
    at gsignal.c line 2239
  • #16 gtk_tree_view_row_activated
    at gtktreeview.c line 9621
  • #17 gtk_tree_view_button_press
    at gtktreeview.c line 2328
  • #18 _gtk_marshal_BOOLEAN__BOXED
    at gtkmarshalers.c line 82
  • #19 g_type_class_meta_marshal
    at gclosure.c line 514
  • #20 g_closure_invoke
    at gclosure.c line 437
  • #21 signal_emit_unlocked_R
    at gsignal.c line 2474
  • #22 g_signal_emit_valist
    at gsignal.c line 2205
  • #23 g_signal_emit
    at gsignal.c line 2239
  • #24 gtk_widget_event_internal
    at gtkwidget.c line 3563
  • #25 gtk_propagate_event
    at gtkmain.c line 2344
  • #26 gtk_main_do_event
    at gtkmain.c line 1582
  • #27 gdk_event_dispatch
    at gdkevents-x11.c line 2133
  • #28 g_main_dispatch
    at gmain.c line 1887
  • #29 g_main_context_dispatch
    at gmain.c line 2433
  • #30 g_main_context_iterate
    at gmain.c line 2514
  • #31 g_main_loop_run
    at gmain.c line 2718
  • #32 gtk_main
    at gtkmain.c line 1172
  • #33 main
    at gnome-desktop-item-edit.c line 189




------- Bug moved to this database by unknown@bugzilla.gnome.org 2004-03-13 16:35 -------

The original reporter (test@_HOSTNAME_.gelwarg.net) of this bug does not have an account here.
Reassigning to the exporter, unknown@bugzilla.gnome.org.
Reassigning to the default owner of the component, gtk-bugs@gtk.org.

Comment 1 Morten Welinder 2004-03-14 01:40:29 UTC
This crash part of this ought to be fixed by making error_dialog
handle a NULL path.

The underlying cause can, I think, be fixed by...

1. Apply the gtkfilechooserdefault.c part of the latest patch from
   http://bugzilla.gnome.org/show_bug.cgi?id=136185.  (That makes
   it stop using get_file_info for verifying directories, in
   particular the root directory for which it doesn't work.)

2. Adding the following to gtk_file_system_unix_get_folder (which
   will make check_is_folder from 1 actually work):

      if (!g_file_test (filename, G_FILE_TEST_IS_DIR))
        {
          int save_errno = errno;
          gchar *filename_utf8 = g_filename_to_utf8 (filename, -1,
NULL, NULL, N
ULL);
          g_set_error (error,
                       GTK_FILE_SYSTEM_ERROR,
                       GTK_FILE_SYSTEM_ERROR_NONEXISTENT,
                       _("file is not a directory '%s': %s"),
                       filename_utf8 ? filename_utf8 : "???",
                       g_strerror (save_errno));
          g_free (filename_utf8);
          return NULL;
        }

    This part should, IMHO, be done in all cases.
Comment 2 Marco Pesenti Gritti 2004-03-14 10:10:50 UTC
*** Bug 137123 has been marked as a duplicate of this bug. ***
Comment 3 Morten Welinder 2004-03-14 20:24:50 UTC
This was trigger by the trailing-slash patch.  I fixed that and the
crash.  (2) above was fixed also, (1) not.