After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 137063 - Higlight Critical Tasks and sub-tasks (0.11)
Higlight Critical Tasks and sub-tasks (0.11)
Status: RESOLVED FIXED
Product: planner
Classification: Other
Component: General
unspecified
Other Linux
: Normal normal
: 0.12
Assigned To: planner-maint
planner-maint
Depends on:
Blocks:
 
 
Reported: 2004-03-13 14:39 UTC by andi
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.3/2.4

Attachments
fixes critical path highlight error (825 bytes, patch)
2004-04-04 19:59 UTC, Doroszlai Attila 		none Details | Review
shows correct highlight of critical tasks (18.62 KB, image/png)
2004-04-04 20:10 UTC, Doroszlai Attila 		  Details

Description andi 2004-03-13 14:39:49 UTC 
Higlight critical tasks does not always work as I would expect. 

- create new project
- enable "higlight critical tasks" from the "view" menu
- insert task A and B , make A predeccessor of B

=> A and B are higlighted (OK)

- inset B1 as subtask of B

=> B1 is highlighted (OK, because B1 determines the duration of B)

- insert A1 as sub-task of A

=> A1 is not highlighted. This seems to be wrong: as A1 determines the
duration for A it should be highlighted.

Highlighting is correct when A1 is predeccessor of B or B1

Ciao
  Andi
Comment 1 Doroszlai Attila 2004-04-04 19:59:17 UTC 
Created attachment 26323 [details] [review]
fixes critical path highlight error

The problem was with the second, backward pass of calculations.  The patch
should be applied after Corey's relation-types patch.
Comment 2 Doroszlai Attila 2004-04-04 20:10:04 UTC 
Created attachment 26324 [details]
shows correct highlight of critical tasks
Comment 3 Richard Hult 2004-04-04 20:13:15 UTC 
Great catch! Thanks a lot, I'll commit this as soon as the relation types patch
is applied.
Comment 4 Richard Hult 2004-04-04 20:14:46 UTC 
Do you think this is the same bug as
http://bugzilla.gnome.org/show_bug.cgi?id=138437?
Comment 5 Doroszlai Attila 2004-04-05 15:31:52 UTC 
Yes, that one is the same bug, latest_finish not being set properly.  With the
patch applied, slack is 0 for subtasks on critical path, too, so you can close
that one as well.
Comment 6 Richard Hult 2004-04-06 20:33:59 UTC 
Committed, thanks a lot!