GNOME Bugzilla – Bug 136987
Alt-Up for GtkFileChooser
Last modified: 2011-02-04 16:16:03 UTC
It feels very odd that even though we retain our original context in the path bar with Alt-Up, we don't support the analogous Alt-Down to go back down the hierarchy we've just come up. Attached is a patch to implement it.
Created attachment 25564 [details] [review] patch
What a good idea! I'll look at it.
Created attachment 25656 [details] [review] For reference, alternate try using GtkPathbar
First looking at the patch, I said "wait, why didn't he just hack in _gtk_path_bar_down" - but with experimentation, it then doesn't reverse the action of Alt-Up on rerooting. Of course, I don't think Alt-Up from [Home] [*otaylor*] [cvs] you with [FS] [home] I think it should leave you with [FS] [*home*] [otaylor] [cvs] But that looks like a pain to implement.
Hmm, playing around with the two patches, I really like my patch where Alt-Up/Alt-Down are confined to the pathbar a lot better. It feels solider and more physical. You don't get [*Home*] Alt-down [Home][*cvs*] Alt-down [Home][cvs][*gnome*] Alt-down [Home][cvs][gnome][*gtk+*] Which feels like it is pulling stuff out of it's hat.
Decided to go ahead and commit my version. Sun Mar 14 21:03:15 2004 Owen Taylor <otaylor@redhat.com> * gtk/gtkpathbar.[ch]: Add _gtk_path_bar_up()/ _gtk_path_bar_down(). * gtk/gtkfilechooserdefault.c: Use _gtk_path_bar_up()/ _gtk_path_bar_down() as bindings for Alt-Up and new Alt-Down. (Partly based on a patch by Mark McLoughlin, #136987)