GNOME Bugzilla – Bug 136915
Improved string function
Last modified: 2005-12-05 12:16:44 UTC
This patch add some new ability to string handling function: - a tokenize function; - a join function ; - some easy text replace functions.
Created attachment 25528 [details] [review] Patch
1. We have been at API freeze since March 1st: http://www.gnome.org/start/2.5/bindings/ So I have to ask why this should break the freeze instead of waiting for gtkmm 2.6. The unstable gtkmm 2.5 will start after 2.4.0 on March 22nd. 2. These are not wrappers for any glib functionality, I think. Or do they have any equivalents in standard C++? Why should they be in glibmm? 3. I think you should pass all std::list and ustring parameters as const references.
1. I know the API freeze. If useful apply the patch on next 2.6 release. 2. These are not wrappers for any glib functionality, I think. They should be in glibmm because they fill a lack in glibmm API (such as tokenize and join). They use Glib::ustring manipulation. 3. I'll do.
2 Do they have any equivalents in standard C++?
Please respond. At the moment, I am unlikely to approve this patch unless it fills an obvious need.