After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 136721 - Crash trying to open preferences for the clock-applet
Crash trying to open preferences for the clock-applet
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: clock
2.5.x
Other other
: High critical
: ---
Assigned To: Panel Maintainers
Panel Maintainers
: 137741 137984 137990 138467 138468 138516 138522 138569 138578 138581 138589 138670 138708 138771 138781 138809 138822 139003 139104 139148 139156 139207 139214 139433 139510 139727 139736 139775 139790 140111 140696 140732 140818 141028 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-03-10 06:35 UTC by Rodd Clarkson
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: 2.6.next
GNOME version: ---


Attachments
patch (2.30 KB, patch)
2004-03-11 11:43 UTC, Mark McLoughlin
none Details | Review
Patch fixing the problem (1.09 KB, patch)
2004-03-11 13:53 UTC, Fernando Herrera
none Details | Review
Updated patch setting correctly the combo (1.49 KB, patch)
2004-03-11 14:06 UTC, Fernando Herrera
none Details | Review

Description Rodd Clarkson 2004-03-10 06:35:24 UTC
Distribution: Fedora Core release 1 (Yarrow)
Package: gnome-panel
Severity: normal
Version: GNOME2.5.91 2.5.x
Gnome-Distributor: GARNOME
Synopsis: Crash trying to open preferences for the clock-applet
Bugzilla-Product: gnome-panel
Bugzilla-Component: clock applet
Bugzilla-Version: 2.5.x
BugBuddy-GnomeVersion: 2.0 (2.5.91)
Description:
Steps to reproduce the crash:
1. Right click the clock applet.
2. Select "preferences"




------- Bug moved to this database by unknown@bugzilla.gnome.org 2004-03-10 01:35 -------

Reassigning to the default owner of the component, gnome-panel-maint@bugzilla.gnome.org.

Comment 1 Vincent Untz 2004-03-10 08:36:14 UTC
Thanks for the bug report. Without a stack trace from the crash it's
very hard to determine what caused the crash. Please see
http://bugzilla.gnome.org/getting-traces.cgi for more information
about getting a useful stack trace.
Comment 2 Rodd Clarkson 2004-03-10 22:33:44 UTC
Sheesh, I thought bug-buddy would have grabbed the stack trace for this.

I'll see if I can rustle up a stack trace some other way.
Comment 3 Fernando Herrera 2004-03-10 23:05:10 UTC
Backtrace was generated from '/mnt/work/gnome25/libexec/clock-applet'

Using host libthread_db library "/lib/tls/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread -1207345024 (LWP 24028)]
0x00971c32 in _dl_sysinfo_int80 () from /lib/ld-linux.so.2

Thread 1 (Thread -1207345024 (LWP 24028))

  • #0 _dl_sysinfo_int80
    from /lib/ld-linux.so.2
  • #1 __waitpid_nocancel
    from /lib/tls/libpthread.so.0
  • #2 libgnomeui_segv_handle
    at gnome-ui-init.c line 741
  • #3 <signal handler called>
  • #4 g_logv
  • #5 g_log
  • #6 update_properties_for_format
    at clock.c line 2084
  • #7 display_properties_dialog
    at clock.c line 2313
  • #8 marshal_VOID__USER_DATA_STRING
    at bonobo-ui-component.c line 221
  • #9 g_closure_invoke
    at gclosure.c line 437
  • #10 bonobo_closure_invoke_va_list
    at bonobo-types.c line 415
  • #11 bonobo_closure_invoke
    at bonobo-types.c line 478
  • #12 impl_Bonobo_UIComponent_execVerb
    at bonobo-ui-component.c line 158
  • #13 _ORBIT_skel_small_Bonobo_UIComponent_execVerb
    at Bonobo-common.c line 1196
  • #14 ORBit_c_stub_invoke
    at poa.c line 2627
  • #15 Bonobo_UIComponent_execVerb
    at Bonobo-stubs.c line 1227
  • #16 real_exec_verb
    at bonobo-ui-engine.c line 1533
  • #17 impl_emit_verb_on
    at bonobo-ui-engine.c line 1591
  • #18 g_cclosure_marshal_VOID__POINTER
    at gmarshal.c line 601
  • #19 g_type_class_meta_marshal
    at gclosure.c line 514
  • #20 g_closure_invoke
    at gclosure.c line 437
  • #21 signal_emit_unlocked_R
    at gsignal.c line 2474
  • #22 g_signal_emit_valist
    at gsignal.c line 2195
  • #23 g_signal_emit
    at gsignal.c line 2239
  • #24 bonobo_ui_engine_emit_verb_on_w
    at bonobo-ui-engine.c line 3040
  • #25 exec_verb_cb
    at bonobo-ui-sync-menu.c line 445
  • #26 g_cclosure_marshal_VOID__VOID
    at gmarshal.c line 77
  • #27 g_closure_invoke
    at gclosure.c line 437
  • #28 signal_emit_unlocked_R
    at gsignal.c line 2436
  • #29 g_signal_emit_valist
    at gsignal.c line 2195
  • #30 g_signal_emit
    at gsignal.c line 2239
  • #31 gtk_widget_activate
    at gtkwidget.c line 3594
  • #32 gtk_menu_shell_activate_item
    at gtkmenushell.c line 901
  • #33 gtk_menu_shell_button_release
    at gtkmenushell.c line 528
  • #34 gtk_menu_button_release
    at gtkmenu.c line 2436
  • #35 _gtk_marshal_BOOLEAN__BOXED
    at gtkmarshalers.c line 82
  • #36 g_type_class_meta_marshal
    at gclosure.c line 514
  • #37 g_closure_invoke
    at gclosure.c line 437
  • #38 signal_emit_unlocked_R
    at gsignal.c line 2474
  • #39 g_signal_emit_valist
    at gsignal.c line 2205
  • #40 g_signal_emit
    at gsignal.c line 2239
  • #41 gtk_widget_event_internal
    at gtkwidget.c line 3563
  • #42 gtk_propagate_event
    at gtkmain.c line 2344
  • #43 gtk_main_do_event
    at gtkmain.c line 1582
  • #44 gdk_event_dispatch
    at gdkevents-x11.c line 2133
  • #45 g_main_dispatch
    at gmain.c line 1887
  • #46 g_main_context_dispatch
    at gmain.c line 2433
  • #47 g_main_context_iterate
    at gmain.c line 2514
  • #48 g_main_loop_run
    at gmain.c line 2718
  • #49 bonobo_main
    at bonobo-main.c line 297
  • #50 bonobo_generic_factory_main_timeout
    at bonobo-generic-factory.c line 384
  • #51 bonobo_generic_factory_main
    at bonobo-generic-factory.c line 341
  • #52 panel_applet_factory_main_closure
    at panel-applet.c line 1556
  • #53 panel_applet_factory_main
    at panel-applet.c line 1580
  • #54 main
    at clock.c line 2446
  • #0 _dl_sysinfo_int80
    from /lib/ld-linux.so.2

Comment 4 Vincent Untz 2004-03-11 09:45:33 UTC
I can't test right now, but I suppose you're using a custom format for
the clock, aren't you?
Comment 5 Mark McLoughlin 2004-03-11 09:52:36 UTC
Just debugging this now. Seems this happens when the format key
contains rubbish.

Guys, could either of you let us know what the output of

gconftool-2 -g
/apps/panel/profiles/default/applets/$(applet-id)/prefs/format


is ?

Note, you'll need to find out the $applet-id for your clock applet.
It'll be one of the ids on
/apps/panel/profiles/default/general/applet_id_list. What will give it
away is that
/apps/panel/profiles/default/applets/$(applet-id)/bonobo_iid  will be
OAFIID:GNOME_ClockApplet
Comment 6 Vincent Untz 2004-03-11 10:16:58 UTC
Mark: I'm just reading the code, but it seems that if the format is
"custom", we select the "custom format" item in the combo box. But
this item is added later. So when update_properties_for_format() is
called for the first time, we have format == -1 because there's no
selected item in the combo box.
Again, I'm just reading the code, so I may be totally wrong :-)
Comment 7 Mark McLoughlin 2004-03-11 10:28:54 UTC
Vincent: try this:

#include <stdio.h>
#include <assert.h>
                                                                     
                                                                         
int
main (int argc, char **argv)
{
  enum { A, B } test_enum = A;
  int test_int = -1;
                                                                     
                                                                         
  test_enum = test_int;
  assert (test_enum < 0);
                                                                     
                                                                         
  return 0;
}

and now find the bug :-)

I'll have a patch in a second, just trying to nail down exactly why
this happens out of curiousity.
Comment 8 Mark McLoughlin 2004-03-11 11:42:13 UTC
Here's the patch, its awaiting releas-team approval
Comment 9 Mark McLoughlin 2004-03-11 11:43:58 UTC
Created attachment 25513 [details] [review]
patch
Comment 10 Fernando Herrera 2004-03-11 12:05:27 UTC
Thanks dudes!
Comment 11 Mark McLoughlin 2004-03-11 12:37:52 UTC
2004-03-11  Mark McLoughlin  <mark@skynet.ie>
                                                                     
                                                                         
        * clock.c: (fill_clock_applet): don't assume enums
        use a signed representation. Fixes crasher bug #136721.
                                                                     
                                                                         
Comment 12 Fernando Herrera 2004-03-11 13:51:59 UTC
Wrong fix. Because it was assumed than the value in the format combo
was in relation with the ClockFormat enum. So with previous patch the
format was set with a -1 offset and crashing when selecting the fist
option.
Fix for this attached.
Comment 13 Fernando Herrera 2004-03-11 13:53:00 UTC
Created attachment 25517 [details] [review]
Patch fixing the problem
Comment 14 Fernando Herrera 2004-03-11 14:06:26 UTC
Created attachment 25520 [details] [review]
Updated patch setting correctly the combo
Comment 15 Fernando Herrera 2004-03-11 15:25:18 UTC
2004-03-11  Fernando Herrera  <fherrera@onirica.com>
 
        * clock.c: (set_format_cb), (display_properties_dialog):
        Fix bug introduced by the last comit. Now valid values
        for ClockFormat begin from 1.
Comment 16 Vincent Untz 2004-03-20 08:56:25 UTC
*** Bug 137741 has been marked as a duplicate of this bug. ***
Comment 17 Mark McLoughlin 2004-03-30 06:10:43 UTC
*** Bug 138467 has been marked as a duplicate of this bug. ***
Comment 18 Mark McLoughlin 2004-03-30 06:10:55 UTC
*** Bug 138468 has been marked as a duplicate of this bug. ***
Comment 19 Mark McLoughlin 2004-03-30 14:40:16 UTC
*** Bug 138516 has been marked as a duplicate of this bug. ***
Comment 20 Mark McLoughlin 2004-03-30 15:15:37 UTC
*** Bug 138522 has been marked as a duplicate of this bug. ***
Comment 21 Mark McLoughlin 2004-03-31 06:17:27 UTC
*** Bug 138569 has been marked as a duplicate of this bug. ***
Comment 22 Mark McLoughlin 2004-03-31 06:18:12 UTC
*** Bug 138589 has been marked as a duplicate of this bug. ***
Comment 23 Mark McLoughlin 2004-03-31 06:19:54 UTC
*** Bug 138578 has been marked as a duplicate of this bug. ***
Comment 24 Mark McLoughlin 2004-03-31 06:20:10 UTC
*** Bug 138581 has been marked as a duplicate of this bug. ***
Comment 25 Vincent Untz 2004-03-31 08:29:38 UTC
*** Bug 137984 has been marked as a duplicate of this bug. ***
Comment 26 Vincent Untz 2004-03-31 08:30:04 UTC
*** Bug 137990 has been marked as a duplicate of this bug. ***
Comment 27 Mark McLoughlin 2004-04-01 07:35:37 UTC
*** Bug 138670 has been marked as a duplicate of this bug. ***
Comment 28 Mark McLoughlin 2004-04-01 07:35:43 UTC
*** Bug 138708 has been marked as a duplicate of this bug. ***
Comment 29 Mark McLoughlin 2004-04-01 18:46:15 UTC
*** Bug 138771 has been marked as a duplicate of this bug. ***
Comment 30 Mark McLoughlin 2004-04-01 21:40:00 UTC
*** Bug 138781 has been marked as a duplicate of this bug. ***
Comment 31 Mark McLoughlin 2004-04-02 07:07:45 UTC
*** Bug 138809 has been marked as a duplicate of this bug. ***
Comment 32 Mark McLoughlin 2004-04-02 07:09:02 UTC
*** Bug 138822 has been marked as a duplicate of this bug. ***
Comment 33 Mark McLoughlin 2004-04-04 15:17:14 UTC
*** Bug 139003 has been marked as a duplicate of this bug. ***
Comment 34 Mark McLoughlin 2004-04-05 06:32:50 UTC
*** Bug 139104 has been marked as a duplicate of this bug. ***
Comment 35 Mark McLoughlin 2004-04-05 16:17:31 UTC
*** Bug 139143 has been marked as a duplicate of this bug. ***
Comment 36 Mark McLoughlin 2004-04-05 17:43:03 UTC
*** Bug 139148 has been marked as a duplicate of this bug. ***
Comment 37 Mark McLoughlin 2004-04-05 17:43:17 UTC
*** Bug 139156 has been marked as a duplicate of this bug. ***
Comment 38 Mark McLoughlin 2004-04-06 06:05:06 UTC
*** Bug 139214 has been marked as a duplicate of this bug. ***
Comment 39 Tim Herold 2004-04-08 13:07:53 UTC
*** Bug 139433 has been marked as a duplicate of this bug. ***
Comment 40 Tim Herold 2004-04-08 22:37:10 UTC
*** Bug 139510 has been marked as a duplicate of this bug. ***
Comment 41 Tim Herold 2004-04-12 01:06:35 UTC
*** Bug 139727 has been marked as a duplicate of this bug. ***
Comment 42 Vincent Untz 2004-04-13 08:10:40 UTC
*** Bug 139790 has been marked as a duplicate of this bug. ***
Comment 43 Vincent Untz 2004-04-13 08:11:17 UTC
*** Bug 139736 has been marked as a duplicate of this bug. ***
Comment 44 Vincent Untz 2004-04-13 08:18:15 UTC
*** Bug 139775 has been marked as a duplicate of this bug. ***
Comment 45 Kjartan Maraas 2004-04-13 14:43:34 UTC
*** Bug 139207 has been marked as a duplicate of this bug. ***
Comment 46 Mark McLoughlin 2004-04-15 13:32:24 UTC
*** Bug 140111 has been marked as a duplicate of this bug. ***
Comment 47 Mark McLoughlin 2004-05-13 10:49:52 UTC
*** Bug 140696 has been marked as a duplicate of this bug. ***
Comment 48 Mark McLoughlin 2004-05-13 10:50:30 UTC
*** Bug 140732 has been marked as a duplicate of this bug. ***
Comment 49 Mark McLoughlin 2004-05-13 10:51:23 UTC
*** Bug 140818 has been marked as a duplicate of this bug. ***
Comment 50 Mark McLoughlin 2004-05-13 11:09:19 UTC
*** Bug 141028 has been marked as a duplicate of this bug. ***