After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 136408 - gst_buffer_merge should take ownership of given buffers
gst_buffer_merge should take ownership of given buffers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: 0.9.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-03-06 21:34 UTC by Benjamin Otte (Company)
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Benjamin Otte (Company) 2004-03-06 21:34:46 UTC
I fixed a lot of memleaks because apps assume gst_buffer_merge takes
ownership of the buffers (which make sense if you want them merged).

It would be nice to make gst_buffer_merge take ownership of the given
buffers, so this works like plugin developers expect it naively.
Comment 1 Ronald Bultje 2004-03-06 21:55:54 UTC
I've noticed and fixed several, too. I vote in favour.
Comment 2 David Schleef 2004-03-31 05:57:14 UTC
Noted in docs/random/ds/0.9-proposed-changes.  Any reason to keep the bug open?
Comment 3 Benjamin Otte (Company) 2004-03-31 23:41:01 UTC
No, unless we want to add a function that does this right now.
Comment 4 David Schleef 2004-04-01 00:40:21 UTC
It seems silly not to just add it right now.  gst_buffer_join().