Robert: please make sure to add the GNOMEVER2.5 keyword if you can,
when it is appropriate. Thanks!

Malcolm - any chance you could take a look at this?

I'm not even sure how to get scrollkeeper to try and validate the OMF
file in oder to see the error ..

make install for gnome-desktop/desktop-docs runs this command :
"scrollkeeper-update -p /home/ximian/opt/gnome2//var/scrollkeeper -o
/home/ximian/opt/gnome2//share/omf/gnome-desktop"

Running scrollkeeper-update with the verbose switch provides this log:

OMF validation error: Element resource content does not follow the
DTD, expecting (creator+ , maintainer* , contributor* , title , date ,
version* , subject* , description? , type* , coverage* , format ,
identifier , language , relation* , source* , rights*), got (title
subject format identifier language )
OMF validation error: Element subject was declared EMPTY this one has
content
OMF validation error: Element subject does not carry attribute category
OMF validation error: No declaration for element category
OMF file [/home/ximian/opt/gnome2//share/omf/gnome-desktop/fdl-C.omf]
does not validate against ScrollKeeper-OMF DTD:
/home/ximian/opt/gnome2/share/xml/scrollkeeper/dtds/scrollkeeper-omf.dtd
Unable to register
/home/ximian/opt/gnome2//share/omf/gnome-desktop/fdl-C.omf
OMF validation error: Element subject does not carry attribute category
OMF validation error: No declaration for element category
OMF file [/home/ximian/opt/gnome2//share/omf/gnome-desktop/gpl-C.omf]
does not validate against ScrollKeeper-OMF DTD:
/home/ximian/opt/gnome2/share/xml/scrollkeeper/dtds/scrollkeeper-omf.dtd
Unable to register
/home/ximian/opt/gnome2//share/omf/gnome-desktop/gpl-C.omf
OMF validation error: Element subject does not carry attribute category
OMF validation error: No declaration for element category
OMF file [/home/ximian/opt/gnome2//share/omf/gnome-desktop/lgpl-C.omf]
does not validate against ScrollKeeper-OMF DTD:
/home/ximian/opt/gnome2/share/xml/scrollkeeper/dtds/scrollkeeper-omf.dtd
Unable to register
/home/ximian/opt/gnome2//share/omf/gnome-desktop/lgpl-C.omf
OMF validation error: Element subject does not carry attribute category
OMF validation error: No declaration for element category
OMF file
[/home/ximian/opt/gnome2//share/omf/gnome-desktop/gnome-feedback-C.omf]
does not validate against ScrollKeeper-OMF DTD:
/home/ximian/opt/gnome2/share/xml/scrollkeeper/dtds/scrollkeeper-omf.dtd
Unable to register
/home/ximian/opt/gnome2//share/omf/gnome-desktop/gnome-feedback-C.omf



Mark/Malcolm : I hope this is helpful...:)

Fixed on HEAD now

In gnome-desktop 2.6.1, the omf files need a <date> tag after the
<title> tag in order to validate.

None of the omf files in gnome-desktop is valid yet.

They are all missing the <creator> element, which should be the first child in
the <resource>.

Here comes a patch that makes "gnu@gnu.org (Free Software Foundation)" which is
pretty sane, I guess.

Created attachment 29099 [details] [review]
Fix the godforsaken omf files

I think it is incorrect to use gnu@gnu.org, since they did NOT create these files.

Use CVS to track down the original creator and use the right value. If that is
impossible, we should think about using a generic @gnome.org address (you'll
need to seek advice about which one to use, we may need to create one or
something). By using gnu@gnu.org you are mis-indicating the creator (which will
be a copyright violation in at least some jurisdictions).

Actually, I read on http://www.ibiblio.org/osrt/omf/omf_elements that 

 	Author or Creator
	Label: CREATOR
	Obligation: Mandatory
	Maximum Occurrence : Repeatable
   The person or organization primarily responsible for creating the
   intellectual content of the resource. CREATOR should appear in RFC822
   format (http://info.internet.isi.edu:80/in-notes/rfc/files/rfc822.txt).
   Preferred format: mailname@site.domain.top (Full Name)

and the licenses are the intellectual property of the FSF.

The gnome-feedback omf files are not FSF's, though, so that should be fixed.

Also, a couple of the omf files are not valid also because they use a <category>
element which does not exist, and the no translation is translating the category
code, which is an opaque string, so yelp will choke on that.

Here comes a patch which fixes this last two issues. It also uses the GNOME
Documentation Project as <creator> for the gnome-feedback files, because they 
hold the copyright, according to the respective files (This is missing the email
address, because the only one I could find is the mailing list; we can interpret
à la rfc2119 the ‘should’ in the spec...)

Also, this adds DOCTYPEs to all the omf files, since having to pass the url of
the DTD in the --dtdvalid command line option to xmllint gets very annoying
after a bit, and, well, files which describe themselves are nice.

Created attachment 29103 [details] [review]
Fix them, only better this time

Revised patch committed on gnome-2-6 and HEAD branches.