After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 135919 - v4l2 plugins don't build on SuSE 9 & Mandrake 10
v4l2 plugins don't build on SuSE 9 & Mandrake 10
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal normal
: 0.8.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 136265 138473 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-03-02 02:19 UTC by Jon Trowbridge
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Check for struct v4l2_buffer in configure.ac (583 bytes, patch)
2004-03-02 02:20 UTC, Jon Trowbridge 		none Details | Review
videodev2.h shipped w/ SuSE 9 (25.76 KB, text/plain)
2004-03-02 04:17 UTC, Jon Trowbridge 		  Details

Description Jon Trowbridge 2004-03-02 02:19:50 UTC 
The configure script detects v4l2, but the build fails on gstv4l2src.h
gcc complains 'error: storage size of `buffer' isn't known' on line 55:

54 struct _GstV4l2Buffer {
55   struct v4l2_buffer	buffer;
56   guint8 *		start;

In the videodev2.h head that ships w/ SuSE 9, the definition of struct
v4l2_buffer is wrapped in #ifdef __KERNEL/#endif.

The path of least resistance is to just check for that struct in
configure.ac.  A patch is attached.
Comment 1 Jon Trowbridge 2004-03-02 02:20:56 UTC 
Created attachment 25014 [details] [review]
Check for struct v4l2_buffer in configure.ac
Comment 2 Ronald Bultje 2004-03-02 03:51:27 UTC 
No no no, that's very wrong. I'll ask this on the v4l mailinglist.
Comment 3 Ronald Bultje 2004-03-02 03:53:27 UTC 
Oh, and please provide a copy of Suse-9.0's videodev2.h - maybe it
helps if I have a look.
Comment 4 Jon Trowbridge 2004-03-02 04:17:04 UTC 
Created attachment 25022 [details]
videodev2.h shipped w/ SuSE 9
Comment 5 Ronald Bultje 2004-03-02 04:46:53 UTC 
Ewh, something's really screwed...

I've asked on the v4l mailinglist, I'll wait for a reply there. If
that's "not good"(tm), you can disable v4l2 here...
Comment 6 Benjamin Otte (Company) 2004-03-04 13:26:53 UTC 
Uh, nice. "Ship your won header" is a nice answer.
Anyway, the bug is in the SUSE header, as the struct is to be used 
by ioctls.

Someone should file a bug against that in Suse.
And we'll gladly take an AC_TRY_COMPILE check for this, too I 
guess. ;)
Comment 7 Ronald Bultje 2004-03-04 18:04:52 UTC 
*nod*. Anyway, Gerd (Suse guy) said on the mailinglist that he'd fix
it in the suse header and acknowledged the bug, that's good enough for
me. Go ahead with the AC_TRY_COMPILE; it'd be cool if, instead of
disabling, you could declare a macro NEED_V4L2_BUF_STRUCT_DEF or so
and declare the struct conditionally somewhere in the gstv4l2*.h
headers. That way, also Suse users can use the v4l2 plugins. :).
Comment 8 Benjamin Otte (Company) 2004-03-05 13:38:03 UTC 
*** Bug 136265 has been marked as a duplicate of this bug. ***
Comment 9 Ronald Bultje 2004-03-30 15:16:37 UTC 
*** Bug 138473 has been marked as a duplicate of this bug. ***
Comment 10 Ronald Bultje 2004-03-30 15:23:46 UTC 
Jon, any progress on this? All those poor Suse users are filing bugs right now. ;).
Comment 11 Robert H. Cobb XX 2004-03-30 20:11:41 UTC 
Actually, Bug 138473 was not a SuSE machine but a Mandrake 10 machine
Comment 12 Ronald Bultje 2004-03-30 20:46:15 UTC 
The bug is the same nevertheless... Adding Mandrake to affected distros. Funny,
this means Mandrake uses Suse's headers.
Comment 13 Ronald Bultje 2004-04-10 13:27:13 UTC 
Fixed in CVS.