After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 135816 - FileChooser/eog crashes when using 'File->Open Directory'
FileChooser/eog crashes when using 'File->Open Directory'
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
git master
Other Linux
: High critical
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-03-01 06:52 UTC by Jens Finke
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: 2.6.next
GNOME version: ---

Attachments
Backtrace (6.71 KB, text/plain)
2004-03-01 06:52 UTC, Jens Finke 		  Details
Quick fix (1.37 KB, patch)
2004-03-05 07:30 UTC, Jonathan Blandford 		none Details | Review

Description Jens Finke 2004-03-01 06:52:13 UTC 
Eye of Gnome uses the GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER mode of the new
file chooser. After rebuilding gtk yesterday the dialog chrashes now in
this mode on disposure. Opening of files works properly, though.
Comment 1 Jens Finke 2004-03-01 06:52:47 UTC 
Created attachment 24967 [details]
Backtrace
Comment 2 Jonathan Blandford 2004-03-03 22:00:50 UTC 
Er, is this a filesel bug or an EOG bug?  It looks like its crashing
in eog_file_selection_dispose.  Can you get a simpler test-case that I
can look at?
Comment 3 Jens Finke 2004-03-04 07:44:15 UTC 
I do think the following snippet of code from eog is valid/correct,
isnt' it? The code crashes at GNOME_CALL_PARENT call:

 41 eog_file_selection_dispose (GObject *object)
 42 {
 43    EogFileSelectionPrivate *priv;
 44          
 45    priv = EOG_FILE_SELECTION (object)->priv;
 46            
 47    if (priv->thumb_factory != NULL) {
 48        g_object_unref (priv->thumb_factory);
 49        priv->thumb_factory = NULL;
 50    }
 51            
 52    GNOME_CALL_PARENT (G_OBJECT_CLASS, dispose, (object));
 53 }

Also it works flawlessly with GTK_FILE_CHOOSER_ACTION_OPEN set as
action property. Any hints maybe?
Comment 4 Luis Villa 2004-03-04 19:33:44 UTC 
Retitling to make it a little more clear what is going on. It's
embarassing to ship a supposedly core piece of the desktop that has a
top-level menu item that causes a segfault; we have to fix this.
Comment 5 Luis Villa 2004-03-05 02:15:00 UTC 
Forgot to cc: jrb and federico earlier.
Comment 6 Jonathan Blandford 2004-03-05 07:30:02 UTC 
eog bug.  Patch attached.
Comment 7 Jonathan Blandford 2004-03-05 07:30:37 UTC 
Created attachment 25191 [details] [review]
Quick fix
Comment 8 Jens Finke 2004-03-05 08:39:58 UTC 
Thank you very much for the patch, Jonathan. Didn't noticed the this
side effect of the new actions directly. Applied the patch to HEAD and
can verify that the problem is fixed.