GNOME Bugzilla – Bug 135634
Incorrect use of GST_ELEMENT_ERROR breaks the build in NetBSD
Last modified: 2004-12-22 21:47:04 UTC
Several files fails to build under NetBSD (and maybe other systems). All errors are of the form: <file>:<line>: error: parse error before "void" This is caused by the way NetBSD defines the NULL symbol and how gstreamer defines the GST_ELEMENT_ERROR macro; from /usr/include/sys/null.h: #define NULL (void *)0 I've fixed all usages of the GST_ELEMENT_ERROR macro to surround NULL with parenthesis, as this is the rigth way to fix this issue (see bug 135116, which is already closed and was about the same thing). I'm afraid this error may reapear in next versions of gst-plugins. It could be nice to have some checks before 'dist' is run, to ensure this won't happen again...
Created attachment 24871 [details] [review] Sample patch
Applied, thanks.