After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 135634 - Incorrect use of GST_ELEMENT_ERROR breaks the build in NetBSD
Incorrect use of GST_ELEMENT_ERROR breaks the build in NetBSD
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other All
: Normal normal
: 0.7.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-02-27 21:52 UTC by Julio Merino
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Sample patch (7.73 KB, patch)
2004-02-27 21:52 UTC, Julio Merino
none Details | Review

Description Julio Merino 2004-02-27 21:52:14 UTC
Several files fails to build under NetBSD (and maybe other systems).  All 
errors are of the form: 
 
<file>:<line>: error: parse error before "void"  
  
This is caused by the way NetBSD defines the NULL symbol and how  
gstreamer defines the GST_ELEMENT_ERROR macro;  
from /usr/include/sys/null.h:  
  
#define NULL (void *)0 
  
I've fixed all usages of the GST_ELEMENT_ERROR macro to surround NULL 
with parenthesis, as this is the rigth way to fix this issue (see bug 
135116, which is already closed and was about the same thing). 
 
I'm afraid this error may reapear in next versions of gst-plugins.  It 
could be nice to have some checks before 'dist' is run, to ensure this 
won't happen again...
Comment 1 Julio Merino 2004-02-27 21:52:52 UTC
Created attachment 24871 [details] [review]
Sample patch
Comment 2 David Schleef 2004-02-27 23:37:48 UTC
Applied, thanks.