There are several problems here, apparent from an examination with
at-poke:

(1) mozilla's menu hierarchy differs from other apps in that menus are
children of toolbar-role objects, etc.
(2) the menus themselves seem to have a broken/incomplete hierarchy;
(3) the action names of the menu items are broken;
(4) the actions themselves are not invokable (i.e. do nothing when
invoked)

2 through 4 are mozilla bugs, #1 implies that gok needs a little
revision to its search algorithm so that we find the menus.

Have these been filed as mozilla accessibility bugs?

Not yet.  You are welcome to do so if you like.

Bill are you taking this one?  I could have a look at fixing part 1...

If you like; I'd prefer to glance at the patch first though, since I
may  not have documented the search implementation very well and so
the right thing to do might not be apparent.

The main oddity with mozilla's hierarchy (aside from obviously broken
stuff) is that the menubar is a child of a toolbar.  I believe that at
present we may assume that toolbars contain toolbar-items (silly me ;-)

thanks

I'm guessing it is gok_spy_is_menu_role that needs to include another
catch case...  i.e. toolbar   ... because obviously toolbars can have
menus ;-)

I can't readily test this potential fix with mozilla so maybe I'll
throw it back to you...  can you try adding a
		(role ==  SPI_ROLE_TOOLBAR) ||

...and see if it fixes it?

the fix would have to be a little more complex than the above, since
the toolbar would not (itself) be a "menu role object" - one thing we
need to do is ensure that we are checking inside toolbar containers
when seeking menus.  But I'll be happy to investigate this one further.

I don't think we should attempt a fix for "#1" above until the mozilla
issues are solved - because we would (if we exposed the menu items)
only be exposing non-functional items to the user (because the mozilla
ATK menu items themselves are incomplete, and non-functional).

depends on mozilla bugs:

http://bugzilla.mozilla.org/show_bug.cgi?id=235687
http://bugzilla.mozilla.org/show_bug.cgi?id=235690

inaddition to the mozilla fixes above (and some other mozilla bugs
regarding the use of AtkStateSet and ATK_STATE_SHOWING), the following
patch to GOK logic is required; GOK doesn't currently expect to find
menus and editboxes inside toolbars (where mozilla puts them).  Patch
fixes that and so far appears not to have significant side-effects
(thoug some additional testing is warranted).

Created attachment 25588 [details] [review]
patch to search more exhaustively inside toolbars

fixed in cvs.