GNOME Bugzilla – Bug 135177
GtkEntry and justification
Last modified: 2011-02-04 16:17:01 UTC
I modified the original gtkentry.[ch] source and added two functions void gtk_entry_set_justify(GtkEntry *entry, GtkJustification jtype); GtkJustification gtk_entry_get_justify(GtkEntry *entry); I went through major parts of the source and made sure, mouse clicks, drag'n drop, text selection, etc. are handled correctly. So far I didn't experience any problems so I would like to open my solution to other developers. I put my replacments here: http://www.informatik.uni-freiburg.de/~gutmann/gtk/gtkentry.h http://www.informatik.uni-freiburg.de/~gutmann/gtk/gtkentry.c and if you do a diff to the original version, you will find out they only differ at a few places. It would be great to see these enhancements in a future version of gtk. -- Steffen Gutmann
Steffen, it is hard for us to do a diff ourselves if you don't tell us what the base version is. Please do a diff yourself, attach it to this report, and add the PATCH keyword when done. That will this defect much harder to ignore. Thanks.
Created attachment 24706 [details] [review] diff of gtk+-2.2.2/gtk/gtkentry,h to patched version
Created attachment 24708 [details] diff of gtk+-2.2.2/gtk/gtkentry.c to partched version
Matthias, sorry I for not mentioning the full gtk version, it is gtk+-2.2.2. Btw, there was a previous report which I didn't see before but it covers the same aspect than mine: id 59799, http://bugzilla.gnome.org/show_bug.cgi?id=59799. -- Steffen
Thanks for the diffs Steffen. We do prefer unified diffs for readability, but these will probably do.
In any case, this needs to be done with an alignment parameter as described in bug 59799. (I'd say that we don't just prefer unified diffs (diff -u) we really require them. Straight diffs as attached here can't be applied if any changes have been made to those files at all.) *** This bug has been marked as a duplicate of 59799 ***