GNOME Bugzilla – Bug 134895
portability fixes, po fixes, etc.
Last modified: 2005-08-15 01:47:51 UTC
1. [po/POTFILES.in, capplets/file-types/Makefile.am, capplets/ui-properties/Makefile.am, schemas/Makefile.am] Sync with what ships in the distribution. 2. [gnome-settings-daemon/Makefile.am, capplets/font/Makefile.am, capplets/sound/Makefile.am] Link order is important on IRIX. 3. [gnome-settings-daemon/Makefile.am] Remove trailing backslash after $(server_in_files). 4. [gnome-settings-daemon/factory.c] C89 doesn't allow non-constant initializers. 5. [gnome-settings-daemon/reaper.c] Don't need bindtextdomain() #define. 6. [capplets/common/capplet-util.h] DEBUG_MSG macro not used. 7. [capplets/common/gnome-theme-info.h, capplets/mouse/gnome-mouse-properties.c, capplets/theme-switcher/gnome-theme-manager.h, capplets/theme-switcher/gnome-theme-save.c, capplets/keybindings/eggcellrendererkeys.h, vfs-methods/themus/themus-properties-view.c] IBM C compiler does not like comma after tailing enum constant. 8. [capplets/accessibility/keyboard/gnome-accessibility-keyboard-properties.c] Need to #include <X11/X.h>, <X11/Xlib.h>. 9. [capplets/accessibility/at-properties/at-startup-session.c] HP-UX compiler doesn't like math with void * types. 10. [capplets/file-types/mime-edit-dialog.c] #undef WID(x) invalid. Use #undef WID. 11. [capplets/theme-switcher/gnome-theme-manager.c] Cannot initialize to {}. Same to just leave the "= {}" off. 12. [capplets/keybindings/eggcellrendererkeys.c] Make sure function definitions match function prototypes. 13. [capplets/windows/Makefile.am] Tru64 UNIX compiler doesn't like a space after -I. It means that there is no default search path. 14. [control-center/capplet-dir.c] rindex() old bsdism. Use strrchr(). 15. [vfs-methods/themus/theme-method.c] #include <libintl.h> as some of its functions are used. No C++ comments in C source files. Deprecate GNU-specific structure initialization (method). It's not C89. 16. [vfs-methods/fontilus/font-method.c] Deprecate GNU-specific structure initialization (method). It's not C89. 17. [vfs-methods/fontilus/font-view.c] <X11/Xft/Xft.h> needs <X11/Xlib.h>. This is automatically included on XFree86-like systems but commercial UNIX vendors don't necessarily follow suit. 18. [typing-break/Makefile.am] Determine at configure time the XScreensaver path/library. /usr/X11R6/lib only valid for Linux. 19. [Makefile.am] Determine at configure time if we should build typing-break. 20. [vfs-methods/themus/Makefile.am] Don't hardcode -g to AM_CFLAGS. 21. [configure.in] a) AC_CHECK_FUNCS() will automatically #define HAVE_<func>. b) Determine XScreensaver libs dynamically so we don't have to hardcode. c) Reorder GNOMECC_CAPPLETS_LIBS as link order is important on IRIX and modify GNOMECC_CAPPLETS_CFLAGS in accordance with path order.
Created attachment 24586 [details] [review] Patch
Adding the GNOMEVER2.5 and PATCH keywords. Upgrading the version and OS to match the reporter's system, and bumping the priority to high because of the patch.
Merged and applied. Thanks