GNOME Bugzilla – Bug 134342
window doesn't resize for audio
Last modified: 2008-05-08 08:54:06 UTC
When having the option "adjust window size to new file" activated (rough translation of mine), and audio visualization deactivated, there is a problem with audio-files. 1. open video, window adjusts 2. open audio, window remains the same 3. select View->1:!, window resizes correctly (no viewport) it obviously should resize to no viewport when opening an audio-file I think.
Mass reassign.
This might be a duplicate of bug 125903.
*** Bug 157746 has been marked as a duplicate of this bug. ***
*** Bug 161002 has been marked as a duplicate of this bug. ***
Created attachment 38473 [details] bvw-hiding-test.patch Test for hiding and showing the BaconVideoWidget. The xine-lib backend seems quite happy to ignore all that :/
Created attachment 38955 [details] [review] bvw-hiding-no-audio-or-vfx.patch This will hide the video widget properly. We still need to handle properly auto-resize on new video sizes, and setting/unsetting visuals, on the fly.
Created attachment 45393 [details] [review] gst part This seems to do the trick for the GStreamer backend, with the same remarks as made above by Bastien.
Raising priority to make maintainers aware of patch.
The maintainers wrote the patch, and it's not finished...
*** Bug 310670 has been marked as a duplicate of this bug. ***
*** Bug 311269 has been marked as a duplicate of this bug. ***
(I applied the gst part of the patch a while ago, so marking that as committed.)
Created attachment 60987 [details] [review] next try I have made a new patch for this. Auto-resize on new videos and setting / unsetting visuals on the fly is already implemented in CVS HEAD. This patch tries to disable "hide controls" if necessary so you don't end up with a totem with an empty window. I'm still not happy when playing an audio file in "compact" mode and active the sidebar. Open for suggestions :)
*** Bug 318450 has been marked as a duplicate of this bug. ***
*** Bug 322393 has been marked as a duplicate of this bug. ***
*** Bug 331239 has been marked as a duplicate of this bug. ***
From bug 322393: > Please look at this screenshot : > http://img292.imageshack.us/my.php?image=screenshottotemmovieplayer0nf.png > > OR, the sidebar could take its place (second screenshot). > http://img491.imageshack.us/my.php?image=screenshottotemmockup2ej.png This looks pretty good to me. Christoph, want to have a go at implementing that? As for your current patch: - please follow the code style (tabs, not spaces; use spaces before brackets, etc.) - pressing 'H' in fullscreen will break it
Only problem with the mockup is that it won't be a sidebar any more. More a bottombar or topbar :)
Well, it should not be a "sidebar" while we're here (I forgot about that bug): see bug #322503
We only show the logo nowadays, when playing audio only and viz are disabled.
*** Bug 437848 has been marked as a duplicate of this bug. ***
*** Bug 532122 has been marked as a duplicate of this bug. ***