After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 134337 - multiload applet graph gets cleared on autohide panels
multiload applet graph gets cleared on autohide panels
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: multiload
2.4.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-02-13 18:03 UTC by Bart Martens
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.3/2.4



Description Bart Martens 2004-02-13 18:03:09 UTC
See https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=102629

Nils Philippsen wrote: "When putting the multiload applet on an autohide
panel, the graph gets cleared when the panel hides or shows again."

I attached a patch to that bug report that fixes the problem.
Comment 1 Dennis Smit 2004-02-13 18:36:09 UTC
I've tried this with CVS head, your patch is a partial solution
(which is already very nice! thank you for that).

However the following problems:

1. It only works for horizontal panels, when a vertical panel hides
it still clears the draw area.

2. There was one compile warning because you use
+load_graph_unalloc_size_pixmap (LoadGraph *g) before declaring
it which makes gcc to assume a prototype, You can fix this by
putting the function above the function that uses it as the first.
Comment 2 Bart Martens 2004-02-15 13:30:13 UTC
Dennis,

Thanks for testing the patch. Partial solution... True. I have only
tested it with a horizontal gnome-panel. But, for now, forget the
patch. I know more now, after some debugging with gdb. See :

https://bugzilla.redhat.com/bugzilla/process_bug.cgi#c10

Your help is most welcome, as the investigation is becoming a bit more
complicated than I expected. :-)
Comment 3 Dennis Smit 2004-02-15 18:59:42 UTC
Your link doesn't work, you might just want to track all the bug
issues here btw. Seen it's a gnome thing not a redhat thing.

Close the bug in redhat and put a reference to the bug here
or something like that.

If you fix the link and have questions i'd love to answer.
__


One solution that came to my mind btw is storing the factor a certain
line is filling up the 'screen', so you can simply redraw
from the list of factors. This also makes the applet scalable
without removing the data.

Others might want to comment on this as well.
Comment 4 Bart Martens 2004-02-16 00:05:38 UTC
> Your link doesn't work

Oops, sorry. This link should work.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=102629
Comment 5 Dennis Smit 2004-02-16 02:13:28 UTC
Alright, thank you for the link, please try to monitor
the bug here tho!


Keep us updated! 

Comment 6 Bart Martens 2004-02-24 11:39:39 UTC
I think the bug is fixed by the patch submitted at bug #127758.
Comment 7 Dennis Smit 2004-02-29 09:00:18 UTC
This is partly fixed by your patch. It does work for UPPER panels
and panels on the LEFT however, it still redraws the applet
for panels on the RIGHT and on the BOTTOM.

Thanks for the excelent debug work in your patch btw. It would be
nice to get this fixed for the other two panel types as well. Not
sure why it isn't fixed for those.

Thanks a lot!.
Comment 8 Bart Martens 2004-02-29 12:50:44 UTC
gnome-applets-2.4.1-1
gnome-panel-2.4.2-1 with the patch of bug #127758

Re-tested, works for all four orientations. Can you help me to
reproduce what you saw?

Thought of killall gnome-panel? Thought of waiting long enough after
changing the orientation to get the multiload applet graph filled again?
Comment 9 Dennis Smit 2004-02-29 13:17:28 UTC
forgot to restart, i am a dumpy

Thanks again Bart.