GNOME Bugzilla – Bug 134333
Devhelp doesn't select book/chapter currently browsed anymore
Last modified: 2005-09-28 18:40:26 UTC
Devhelp doesn't select book/chapter currently browsed anymore, like it used to do. That is of great help when having two version of docs (like stable and dev ones) installed, as search result usually are indentical in that case making it next to impossible to distinguish which one is selected. Probably there should be more sophisticated way of finding out current book anyway, but this one was good enough to be sorely missed :).
Not sure I'm following you here, where doesn't it select? In what version did it behave the way you liked it?
It doesn't select (ie. unfold and highlight) correct book/chapter in side pane tab containing list of all books after you get to that chapter by searching for given keyword. Can't really remember in what version it got changed, but I think it was on gtk1->gtk2 transition (IIRC, the one shipped with Debian Woody, which happens to be 0.3, was the one with correct behavior) The problem can be seen clearly with attached screenshot, what was searched for was "gtk_block_comment_tag_new". There is no way to tell which book currently browsed chapter belongs to.
Created attachment 24401 [details] Screenshot showing problem
*** Bug 135534 has been marked as a duplicate of this bug. ***
This bug is still in 0.8.1, please update the version
The code for this feature is already written, but seems it needs some fixation. See dh_book_tree_show_uri in http://cvs.gnome.org/viewcvs/devhelp/src/dh-book-tree.c?view=markup
I have written a patch. It works. Now the book tree selection follows the actual page displayed on the right pane, but if I click on links from one of the last items of my book collection (about 50 first level entries in the tree) it takes more than half a second to display the html page, since the whole tree is parsed (gtk_tree_model_foreach) to match the clicked/searched link. I will try to speed up the patch a bit before posting it here. Any idea is highly appreciated :)
This is why it was disabled, ie, a change internally. We have started working on a new version of Devhelp though that will have this functionality.
How many entries do you have in your tree? I can't really see how going through, say, a few thousand rows would take any noticable time...
Created attachment 52754 [details] [review] Improved syncing Could you try this patch and see if it's slow? It seems to work well for me, but I don't have that many nodes.
I'll close here, please reopen if it's not fast enough.
Testing the patch right now. Much much better. Now the tree (about 50 top level entries) is updated almost immediately. Thanks.
I'm about to commit a new version that should feel even better, since it updates the tree before updating the HTML view.