After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 134301 - gst-plugins should depend on X
gst-plugins should depend on X
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal normal
: 0.8.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-02-13 08:40 UTC by Benjamin Otte (Company)
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Benjamin Otte (Company) 2004-02-13 08:40:56 UTC
currently we build libgstinterfaces.so with different features depending on
wether X is installed or not. There is however no way to figure out (at
least not with pkg-config) what version was installed and nobody checks it.

I believe the correct way would be to require X in gst-plugins and not
build parts of that lib conditionally.

Opinions?
Comment 1 Thomas Vander Stichele 2004-02-24 17:48:40 UTC
it should be possible to build without X too, ie. the audio mixer
interface should still work even when X is not present.
Comment 2 David Schleef 2004-02-24 21:14:38 UTC
xoverlay.h only depends on X for the definition of XID.  XID is
unsigned long on all architectures, so changing to unsigned long in
the header makes it independent of X.

xoverlay.c should be compiled and linked into the library
unconditionally, and if X is not present at compile time, all the
function calls can be stubbed out and do nothing.

It's not particularly elegant, but it's clean, and nobody in their
right mind will compile gst-plugins without X.  (From experience, I
know that embedded systems designers and Windows developers are not in
their right minds.)
Comment 3 Benjamin Otte (Company) 2004-02-25 13:26:42 UTC
XOverlay does not depend on any X headers, so it's probably only 
needed for set_xwindow_id.

In that case we should make the window_id argument an unsigned long 
and voila - no more X requirement.

XWindowListener should be made a plugin apparently, so 
libgstinterfaces can be compiled unconditionally.
Comment 4 David Schleef 2004-03-25 03:10:44 UTC
This appears to have been fixed.  I've compiled gst-plugins without X installed
(actually, with nothing but gstreamer+dependencies) and it compiles fine.