After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 134247 - install creates directory when it's not needed
install creates directory when it's not needed
Status: RESOLVED FIXED
Product: GConf
Classification: Deprecated
Component: gconf
CVS HEAD
Other All
: Normal minor
: ---
Assigned To: GConf Maintainers
GConf Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-02-12 18:07 UTC by Julio Merino
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for doc/gconf/Makefile.am (842 bytes, patch)
2004-02-12 18:08 UTC, Julio Merino 		needs-work Details | Review
New patch that works... (1.01 KB, patch)
2004-02-13 12:47 UTC, Julio Merino 		none Details | Review

Description Julio Merino 2004-02-12 18:07:35 UTC 
The Makefile.am file in doc/gconf checks if there are files in 
doc/gconf/html, proceding to install them in the system if some are 
found.  It also creates the target directory where they will be installed 
(obviously). 
 
The problem is that the directory is created before any check is done, so 
an empty directory will be created in the system even if nothing will be 
installed into it. 
 
This does not cause more problems that beeing "ugly", since the GConf 
package in pkgsrc needs to take care of this empty directory, and could 
be desireable if it hadn't to. 
 
The fix I attached moves the mkinstalldirs call inside the conditional.
Comment 1 Julio Merino 2004-02-12 18:08:06 UTC 
Created attachment 24366 [details] [review]
Patch for doc/gconf/Makefile.am
Comment 2 Julio Merino 2004-02-13 12:46:44 UTC 
Sorry, that patch is completely broken.  I've attached a new one 
that works properly. 
 
By the way, you may consider using gtk-doc.make instead of keeping 
an internal copy of it in doc/gconf/Makefile.am, so you benefit from 
fixes done to that file.
Comment 3 Julio Merino 2004-02-13 12:47:56 UTC 
Created attachment 24383 [details] [review]
New patch that works...
Comment 4 Mark McLoughlin 2004-06-12 08:44:26 UTC 
Thanks for the patch. Committed on HEAD and gnome-2-6

2004-06-12  Mark McLoughlin  <mark@skynet.ie>

        Patch from Julio M. Merino Vidal <jmmv@menta.net>
        in bug #134247.

        * doc/gconf/Makefile.am: don't create a directory if
        its not needed.