GNOME Bugzilla – Bug 134231
Improve registration of the DTD in the XML catalog
Last modified: 2004-12-22 21:47:04 UTC
The current build system assumes that the system-wide XML catalog resides in /etc/xml/catalog. This also assumes that the user wants the DTD to be registered in it automatically, using the xmlcatalog utility which may be missing. This is broken: 1) The packaging system (pkgsrc in this case) may opt to place the catalog file somewhere else to keep it under its control. If it does, the path will be different and break. 2) The packaging system (also pkgsrc) may choose to register entries in the catalog itself, for the same reason above (keep exact control of what has been done). This will also break because the current build system registers the DTD unconditionally. 3) xmlcatalog may not exist, thus calling it will fail (though I doubt this could bring problems given the '-' preceding the call). What I propose (patch attached) is the addition of a --with-catalog flag (or rename it to whatever you prefer) so that the user can specify which catalog file to use. If the option is not given, the default and standard /etc/xml/catalog is used. If it's given, the catalog will be the one the user specified. In both of these cases, the script will check for the xmlcatalog utility and use it. Otherwise, if --without-catalog is given, the catalog entry won't be registered and no further actions will be taken. I hope this convinces you that this patch is a Good Thing (TM) to have in libglade ;-)
Created attachment 24356 [details] [review] Patch to implement --with-catalog
Any reason about why this has not been applied yet? It could have been very good if the just published 2.4.0 included it.... FWIW, I've just checked and it still applies correctly to CVS HEAD.
This should now be fixed in CVS. *** This bug has been marked as a duplicate of 77833 ***