GNOME Bugzilla – Bug 134057
bonobo file storage and listContents
Last modified: 2004-12-22 21:47:04 UTC
Bonobo file storage object doesn't correctly executes listContents method of Bonobo::Storage. Instead of getting contents in moniker_path/path it returns contents of moniker_path(without addition of path argument). For example object = bonobo_get_object ("/home"...); then Bonobo_Storage_listContents (object, "/user"); will return contents of /home instead of contents of /home/user. This is caused by this code from gnome-vfs/moniker/bonobo-storage-fs: if (!(dir = opendir (storage_fs->path))) goto list_contents_except; instead of fullname = concat_dir_and_file (storage_fs->path,path); if (!(dir = opendir (fullname))) goto list_contents_except;
Created attachment 24307 [details] [review] Patch
What's the user impact of this problem? why is it high/critical?
looks fine to commit to me.
Comment on attachment 24307 [details] [review] Patch Adding accepted-commit_now flag as per michael's comment.
Nickolay, feel free to commit if you have CVS access
Commmitted to HEAD, thanks for the patch