After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 133817 - add support for disc number tag
add support for disc number tag
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.7.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-02-08 20:00 UTC by Christophe Fergeau
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstreamer patch (1.57 KB, patch)
2004-02-08 20:01 UTC, Christophe Fergeau 		none Details | Review
gst-plugins patch (2.98 KB, patch)
2004-02-08 20:02 UTC, Christophe Fergeau 		none Details | Review
updated disc patch (9.28 KB, patch)
2004-02-21 13:59 UTC, Christophe Fergeau 		none Details | Review

Description Christophe Fergeau 2004-02-08 20:00:24 UTC 
The attached patch adds support for tags indicating the current disc number
and the total number of discs for multi-cd albums. I also modified the mad
plugin and the shared vorbiscomment code to handle it. 
I only tested the mad plugin though.
Comment 1 Christophe Fergeau 2004-02-08 20:01:45 UTC 
Created attachment 24207 [details] [review]
gstreamer patch
Comment 2 Christophe Fergeau 2004-02-08 20:02:57 UTC 
Created attachment 24209 [details] [review]
gst-plugins patch
Comment 3 Christophe Fergeau 2004-02-21 13:59:15 UTC 
Here is an updated gst-plugins patch.
I tested transcoding from mp3 to vorbis, and the disc tags are
properly kept. I also cleaned vorbisenc a bit to make it use some of
the functions defined in gst/tags/gstvorbistag, sorry for mixing those
changes in the disc patch.
Comment 4 Christophe Fergeau 2004-02-21 13:59:54 UTC 
Created attachment 24627 [details] [review]
updated disc patch
Comment 5 Benjamin Otte (Company) 2004-02-22 15:14:32 UTC 
applied to cvs useing GST_ALBUM_VOLUME_* instead of GST_ALBUM_DISC_*
to be more generic