GNOME Bugzilla – Bug 133800
fixes for underquoted macros and automake 1.8.x
Last modified: 2005-08-15 01:51:07 UTC
using automake 1.8.x, everytime i compile a program (well, running autogen in fact), it complains about : /usr/share/aclocal/gst-element-check-0.7.m4:7: warning: underquoted definition of AM_GST_ELEMENT_CHECK /usr/share/aclocal/gst-element-check-0.6.m4:7: warning: underquoted definition of AM_GST_ELEMENT_CHECK and about twenty others similar errors in automake macros from other projects so, perhaps it is an automake 1.8.2 bug or it is that this new automake is more strict and this macro definition is not totally syntaxically conformant. others that feel bad with automake 1.8.2 are (not part of gstreamer) /usr/share/aclocal/vorbis.m4:9: warning: underquoted definition of XIPH_PATH_VORBIS run info '(automake)Extending aclocal' or see http://sources.redhat.com/automake/automake.html#Extending%20aclocal /usr/share/aclocal/sdl.m4:11: warning: underquoted definition of AM_PATH_SDL /usr/share/aclocal/pkg.m4:5: warning: underquoted definition of PKG_CHECK_MODULES /usr/share/aclocal/pilot-link.m4:1: warning: underquoted definition of AC_PILOT_LINK_HOOK /usr/share/aclocal/ogg.m4:8: warning: underquoted definition of XIPH_PATH_OGG /usr/share/aclocal/linc.m4:1: warning: underquoted definition of AM_PATH_LINC /usr/share/aclocal/libxslt.m4:14: warning: underquoted definition of AM_PATH_XSLT /usr/share/aclocal/libraw1394.m4:6: warning: underquoted definition of AC_LIB_RAW1394_FLAGS /usr/share/aclocal/libraw1394.m4:19: warning: underquoted definition of AC_LIB_RAW1394_HEADERS /usr/share/aclocal/libraw1394.m4:41: warning: underquoted definition of AC_LIB_RAW1394_LIBVERSION /usr/share/aclocal/libraw1394.m4:75: warning: underquoted definition of AC_LIB_RAW1394_RUNTEST /usr/share/aclocal/libraw1394.m4:138: warning: underquoted definition of AC_LIB_RAW1394 /usr/share/aclocal/libmikmod.m4:11: warning: underquoted definition of AM_PATH_LIBMIKMOD /usr/share/aclocal/libfame.m4:6: warning: underquoted definition of AM_PATH_LIBFAME /usr/share/aclocal/libOggFLAC.m4:7: warning: underquoted definition of AM_PATH_LIBOGGFLAC /usr/share/aclocal/libOggFLAC++.m4:8: warning: underquoted definition of AM_PATH_LIBOGGFLACPP /usr/share/aclocal/libFLAC.m4:7: warning: underquoted definition of AM_PATH_LIBFLAC /usr/share/aclocal/libFLAC++.m4:8: warning: underquoted definition of AM_PATH_LIBFLACPP /usr/share/aclocal/gtk-2.0.m4:8: warning: underquoted definition of AM_PATH_GTK_2_0 /usr/share/aclocal/gst-element-check-0.7.m4:7: warning: underquoted definition of AM_GST_ELEMENT_CHECK /usr/share/aclocal/gst-element-check-0.6.m4:7: warning: underquoted definition of AM_GST_ELEMENT_CHECK /usr/share/aclocal/gob2.m4:7: warning: underquoted definition of GOB2_HOOK /usr/share/aclocal/gnet-2.0.m4:8: warning: underquoted definition of AM_PATH_GNET_2_0 /usr/share/aclocal/glib-gettext.m4:378: warning: underquoted definition of AM_GLIB_GNU_GETTEXT /usr/share/aclocal/glib-gettext.m4:379: warning: underquoted definition of AM_GLIB_DEFINE_LOCALEDIR /usr/share/aclocal/glib-2.0.m4:8: warning: underquoted definition of AM_PATH_GLIB_2_0 /usr/share/aclocal/gconf-2.m4:8: warning: underquoted definition of AM_GCONF_SOURCE_2 /usr/share/aclocal/freetype2.m4:7: warning: underquoted definition of AC_CHECK_FT2 /usr/share/aclocal/esd.m4:10: warning: underquoted definition of AM_PATH_ESD /usr/share/aclocal/esd.m4:175: warning: underquoted definition of AM_ESD_SUPPORTS_MULTIPLE_RECORD /usr/share/aclocal/avifile.m4:21: warning: underquoted definition of AM_PATH_AVIFILE /usr/share/aclocal/audiofile.m4:12: warning: underquoted definition of AM_PATH_AUDIOFILE /usr/share/aclocal/ao.m4:9: warning: underquoted definition of XIPH_PATH_AO /usr/share/aclocal/aalib.m4:12: warning: underquoted definition of AM_PATH_AALIB /usr/share/aclocal/ORBit2.m4:4: warning: underquoted definition of AM_PATH_ORBIT2
I'm attaching a monster of a patch that replaces all underquoted definitions with properly quoted definitions. It's 82 kB large and needs to be applied from the directory above gst-all, gst-player, gst-plugins, gst-python, etc. This bug is also related to #133126, #133150, #133178, #133214, #133217, #133222, and #133227. There are some others, but I can't recall them offhand.
Created attachment 24205 [details] [review] Proposed patch
Hmm, I guess that Bugzilla doesn't like my fancy newfangled number signs. Let's try this. Bug 133126, bug 133150, bug 133178, bug 133214, bug 133217, bug 133222, and bug 133227. By the way, one has to append the --strip=0 aka -p 0 parameter to patch for the patch to apply.
Ouch, I just realized that there's a big error that I made. Gimme a moment and I'll attach an updated patch.
Created attachment 24206 [details] [review] Correct patch
thanks for the patch. all relevant bits are commited to all relevant modules, and some files have been removed.