After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 133410 - gstid3tag doesnt handle track-count
gstid3tag doesnt handle track-count
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Windows
: Normal normal
: 0.7.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-02-04 14:48 UTC by Charles Schmidt
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
possible patch (907 bytes, patch)
2004-02-04 15:00 UTC, Charles Schmidt 		none Details | Review

Description Charles Schmidt 2004-02-04 14:48:23 UTC 
The id3v2 specification says about the TRCK frame:

   The 'Track number/Position in set' frame is a numeric string
   containing the order number of the audio-file on its original
   recording. This MAY be extended with a "/" character and a numeric
   string containing the total number of tracks/elements on the original
   recording. E.g. "4/9".

gstid3tag.c currently ignores this by converting the string to a number
using strtoul.  If the string following the number is not the end of the
string, the tag doesn't get added.  There should be a check, similar to how
GST_TAG_DATE is formatted properly to catch GST_TAG_TRACK_NUMBER and
GST_TAG_TRACK_COUNT in the case that TRCK appears as number/total.
Comment 1 Charles Schmidt 2004-02-04 15:00:56 UTC 
Created attachment 24057 [details] [review]
possible patch
Comment 2 Benjamin Otte (Company) 2004-02-04 23:25:17 UTC 
added to my local tree, will commit after 0.7.4 is out.
Comment 3 Thomas Vander Stichele 2004-02-24 16:10:30 UTC 
commit verified.