GNOME Bugzilla – Bug 133233
[PATCH] [tcpsink] check possible inet_aton() usage
Last modified: 2005-03-25 19:18:06 UTC
gst/tcp/gsttcpsink.c uses inet_aton(). This function is not available everywhere, so the modules needs to be disabled, when this function is not available (or better a replacement should be used)
Created attachment 23996 [details] [review] adds missing function if not present
Created attachment 23997 [details] [review] add missing test to configure.ac
Created attachment 24014 [details] [review] patch for gst/udp/gstudpsrc.c.
Created attachment 24015 [details] [review] corrected patrch to gsttcpsink.c
Created attachment 24024 [details] [review] and another reference to inet_aton
I don't think it's a good idea to include our own copy of inet_aton as. It is deprecated anyway. The correct way seems to be to use inet_pton and/or gethostbyname. ORBit might give some pointers on how to do it correctly.
inet_pton seems to be not portable as well (at least I don't have this on the sun), gethostbyname() is available though. The supplied patch is definitely not nice (more kind of hotfix), which actually is uased by many other applications in this form (from gnu screen to midnight commander).
Stefan, given that the old tcp elements are now deprecated - can you look at the same issue in server/client src/sink and advise ?
I switched from the solaris box to SuSe91. for GStreamer development as compiling all gst from CVS takes ages on this old solaris box.
right, but you can still check if it's portable or not, no ? :) otherwise we can't do anything about this bug.
status update please
then just close the report, today I've tried to build the latest gst-cvs and there are other packages that I would need (popt).
DON'T milestone to next release without a possible resolution
Since Stefan can no longer help, unfortunately marking as WONTFIX. If it is still an issue, people will re-report it.