GNOME Bugzilla – Bug 133071
--disable-crash-dialog doesn't work
Last modified: 2006-05-02 10:26:16 UTC
Hi, http://bugs.debian.org/230503 I want to get a coredump from blackjack, but I keep getting the gnome crash dialog instead. I tried --disable-crash-dialog, but it seems to have no effect.
Wrong debian bug number. BTW it is confirmed by fejj. a problem with G_PARAM_CONSTRUCT_ONLY
Created attachment 24038 [details] [review] crash-dialog.patch
patch applied to CVS
Are you sure this is the right patch ? The dialog box is definitely gone with this patch.
I reopen this bug. Still here even with the patch
With the patch from bug 131867 now comitted, the --disable-crash-dialog option should now correctly disable the crash dialogue, and otherwise show that dialogue. Can you confirm that it works now? It does work for me.
It doesn't work for me. Both patches apllied against 2.4.0
this is still a problem in libgnomeui-2.6.0
Created attachment 26491 [details] [review] disable_crash_dialog_simplify_implementation.patch This bug is indeed still present in libgnomeui CVS HEAD. Attached patch to fix it by only calling libgnomeui_segv_setup in libgnomeui_post_args_parse. You may not want to apply this patch as-is, but it shows a way to simplify the code paths to get rid of this bug once and for all.
Yeah, the cause to this bug is still present. Currently it sets up the segv handler in pre_args_parse as well as post_args_parse, and it looks like there was meant to be some magic when it was called from pre_args_parse that... well.. exactly. The magic is unimplemented. There's no sensible way to determine if the segv handler should be registered until after you parse args, so it just ended up always registering the handler whether or not you disabled it on the command line. The patch I wrote to fix this is similar to Scott's in that it just rips the broken code out, along with some confusing double-negatives, but is included for reference anyway.
Created attachment 30707 [details] [review] only call libgnomeui_segv_setup once
Created attachment 30708 [details] [review] a working version (atoi on NULL considered harmful)
Any reason not to commit this?
It doesn't apply cleanly any more. Sorry about that.
Created attachment 48659 [details] [review] Updated patch Yeah, I had to update the patch yesterday. I tested it, and it indeed brings back support of --disable-crash-dialog here. (This is shipped in Debian.)
It still doesn't apply to HEAD: [kmaraas@localhost libgnomeui]$ patch < ~/libgnomeui-crash-dialog-fix.patch patching file gnome-ui-init.c Hunk #1 FAILED at 88. Hunk #2 FAILED at 277. Hunk #3 FAILED at 533. Hunk #4 succeeded at 667 (offset 8 lines). 3 out of 4 hunks FAILED -- saving rejects to file gnome-ui-init.c.rej
Created attachment 48662 [details] [review] updated patch for HEAD Attaching an updated patch. Please check if this is ok for the Win32 case as well.
Sorry, I updated the patch to match the 2.10 tarball, not HEAD. (I can't check for Win32, and I probably won't check for 2.11 before 2.12 is prepared for Debian.)
no problem, I'll ask the win32 maintainer to look it over.
The patch looks good to me, and changes nothing in win32 (crash dialogue setup is #ifndef G_OS_WIN32). Kjartan, can we apply this now?
*** Bug 321581 has been marked as a duplicate of this bug. ***
If it's been tested and found to work it's ok by me. Go ahead and commit to both branches.
Checked in, and verified with gnome-crash from bug-buddy.
I tried with gnome 2.14, eog --disable-crash-dialog kill -SEGV `pgrep eog` The crash dialog still come up. But when I did, GNOME_DISABLE_CRASH_DIALOG=1 eog kill -SEGV `pgrep eog` A core file is generated. Can anyone tell me what releases has the patch been checked into? Thanks.
Should be fixed in 2.14.1.
Thanks, Chpe ;)