After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 132514 - Set a max height on the expandable entry
Set a max height on the expandable entry
Status: RESOLVED FIXED
Product: gossip
Classification: Deprecated
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Gossip Maintainers
Gossip Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-01-26 02:43 UTC by Mikael Hallendal
Modified: 2006-09-07 18:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (3.26 KB, patch)
2006-09-06 22:55 UTC, Xavier Claessens 		none Details | Review
better like that (3.09 KB, patch)
2006-09-07 15:22 UTC, Xavier Claessens 		none Details | Review

Description Mikael Hallendal 2004-01-26 02:43:16 UTC 
When pasting a lot of text the entry forces the window to become bigger
which isn't very nice.
Comment 1 Richard Hult 2006-04-23 08:13:48 UTC 
It would  be nice if we somehow could have the entry use scrollbars when if reaches the max size just before starting to expand the window, and disable them again when it shrinks.
Comment 2 Xavier Claessens 2006-09-06 22:55:45 UTC 
Created attachment 72357 [details] [review]
proposed patch

if the input rush MAX_INPUT_HEIGHT a scrollbar appear and so the height doesn't grow anymore. If the scroll is no more needed it's removed and the input's height can decrease again.
Comment 3 Richard Hult 2006-09-07 15:03:57 UTC 
Oh, cool! I wasn't sure this was actually possible to do.

One small comment, 

+	g_value_init (&value, G_TYPE_INT);
+	g_value_set_int (&value, -1);
+	g_object_set_property (G_OBJECT (sw), "height-request", &value);

could be replaced by g_object_set (sw, "height-request", -1, NULL);
Comment 4 Xavier Claessens 2006-09-07 15:22:32 UTC 
Created attachment 72377 [details] [review]
better like that

Yeah, that's better with g_object_set() ;-)
Comment 5 Richard Hult 2006-09-07 18:06:54 UTC 
Committed, thanks.