After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 132352 - Intelligent scissors tool fails to move terminal points
Intelligent scissors tool fails to move terminal points
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
1.x
Other All
: Normal normal
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2004-01-24 01:37 UTC by codemstr
Modified: 2006-08-14 12:33 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description codemstr 2004-01-24 01:37:59 UTC
Description of Problem:
It seems you are only able to move a non-
terminal (i.e. not the most recently, or first 
created point) even though the little four-way 
arrow is displayed when you move the pointer 
over a terminal point.

Steps to reproduce the problem:
1. Create a new image
2. Select the intelligent scissors tool
3. Create a few points
4. Attempt to "move" the most recently created 
point

Actual Results:
Step 4 above fails and instead of moving the 
most-recently-created point, it creates a new 
point. Same occurs if you attempt to move the 
first-created point.

Expected Results:
I'd expect it to actually move the point. Gimp 
does display the four-way arrow rather than 
the "+" which indicates it does intend to move 
the point, though it does not.

How often does this happen? 
Everytime.

Additional Information:
Gimp 2.0-pre2 under WinXP Home.
Comment 1 Michael Natterer 2004-01-24 16:53:00 UTC
Confirmed. Should hopefully be an easy fix.
Comment 2 Michael Natterer 2004-01-29 13:12:05 UTC
Well, it's not an easy fix. Moving the terminal is explicitly
disabled. I tried to enable it naively but the whole tool
broke badly.

That code seems to be so fragile, we should not change it for 2.0.
Comment 3 Sven Neumann 2004-10-22 23:18:35 UTC
Since noone is actively working on this it shouldn't block the 2.2 release.
Comment 4 weskaggs 2006-06-16 15:40:17 UTC
Upgrading target milestone from Future to 2.6.
Comment 5 Raphaël Quinet 2006-06-21 13:41:34 UTC
There are two things to consider:
- While the list of points is still being defined (shape not closed yet), all
  points except the terminal points can be moved.  Unfortunately, as the
  reporter mentioned, the cursor shows the "move" option even for the terminal
  points.
- Once the shape is closed, all points can be moved.

I think that it does make sense to have a different behavior for the terminal points while the shape is still open, otherwise it would be very difficult to create points that are very close to each other (problem with last point) or to close the shape (problem with first point).

So the main problem is that the cursor shows the "move" option for these points, but it should not do that.  It should keep the normal "+" cursor (adding a new point) while the mouse over the last point and use a new "connect" cursor (similar to the two circles used in the vector/path tool) while the mouse is over the first point.

Ensuring that the cursor is updated correctly and reflects what will actually be done should be the right way to solve this problem.  I had a quick look at the code and it may still be possible to fix this for 2.4 (but I didn't change the milestone).
Comment 6 Raphaël Quinet 2006-06-21 13:44:21 UTC
The "connect" cursor should only be used for the first point if there are already more than 2 points defined.  Otherwise, it should probably show a "forbidden" cursor or something like that.
Comment 7 Sven Neumann 2006-08-14 12:33:27 UTC
2006-08-14  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpiscissorstool.c (gimp_iscissors_tool_oper_update):
	do not select ISCISSORS_OP_MOVE_POINT for terminal points. Fixes
	bug #132352.