GNOME Bugzilla – Bug 132316
terminal widget's context menu posting isn't exposed as an AtkAction
Last modified: 2007-01-22 20:01:48 UTC
vte has a context menu when focussed, but there's no AtkAction exposed on the focussable widget to pop it up. there ought to be a 'menu' action, in line with the solution for nautilus (see bug 132156).
Created attachment 23761 [details] [review] Proposed patch
In addition to adding AtkAction this patch removes implementation for atk_grab_focus as the implementation in gail_widget.c is better.
Created attachment 23845 [details] [review] Corrected patch - deals with return value from popup-menu signal
Upping pri. Please review and commit if it's ok.
Apologies for spam-- ensuring Sun a11y team are cc'ed on all current a11y bugs. Filter on "SUN A11Y SPAM" to ignore.
Ping? The argument is sound and the patch looks sane. Commit?
As Will suggests, I think this patch could be dangerous to accessibility. Please let's have some more discussion, I haven't had time to review it yet
Just to check that I haven't confused you in a flurry of review requests... I presume comment #7 was actually addressed to bug 398006?
Hi Chris, thanks, yes. Sincere apologies for the confusion!
No idea about this one. If it does the job, feel free to commit it, but please make sure Rich tests it.
r1496: 2007-01-22 Chris Wilson <chris@chris-wilson.co.uk> Bug 132316 – terminal widget's context menu posting isn't exposed as an AtkAction Original patch by <padraig.obriain@sun.com> * src/vteaccess.c: (vte_terminal_accessible_free_private_data), (vte_terminal_accessible_component_init), (vte_terminal_accessible_do_action), (vte_terminal_accessible_get_n_actions), (vte_terminal_accessible_action_get_description), (vte_terminal_accessible_action_get_name), (vte_terminal_accessible_action_get_keybinding), (vte_terminal_accessible_action_set_description), (vte_terminal_accessible_action_init), (vte_terminal_accessible_get_type): Remove grab_focus and defer to the parent's implementation. Add an AtkAction iface.
Rich asked me to take a look at this one as well. Having installed revision 1497, I'm not noticing any differences in Orca's behavior when navigating in gnome-terminal's context menu. (Should I be?)