GNOME Bugzilla – Bug 132146
New Palette based color selector module
Last modified: 2007-03-13 13:49:00 UTC
[Bex asked me to file this bug, since she has weird problems using bugzilla] It would be cool to have a color selector module that offers a choice of the available palettes and picks colors from the palette.
What's wrong with the Palette Editor?
If I understood bex correctly it is not at the same point where the other color selectors are.
I am not sure if it makes sense to replicate the palettes functionality as a color selector module. Actually I don't see any advantage of doing that. Basically the only use of palettes as they are currently implemented is to provide colors to pick from. Integrating this functionality into the color selectors would be quite tricky both from a development and from a user interface point of view. I suggest to close this report as WONTFIX.
It might be interesting to do some changes to the Palette Editor. It could be combined with a palettes menu so that it could be used w/o the Palettes list. It should also probably be accessible from the menus so you don't have to go thru the Palettes dialog to get to the Palette Editor.
As a regular user and seeing as the main points of palettes is picking colors, it really would make more sense to me to have palettes in the same place as the other color selectors. It's just a different way of picking a color. I can't figure out a way, with the pre2.0-2 palette stuff, to pick a background color from a palette. I'd have to pick it to the foreground then swap. My little brain wants to left-click the background color then select some palettes tab in which i can pick a palette then select a color like in the color editor.
Like in all other places where colors can be picked in The GIMP, you need to press Ctrl if you want to pick the background color instead of the foreground color.
It might be useful for idiot users to add "Set to FG" and "Set to BG" to the right-click menu in the palette editor. Then they can probably find it even if they can't figure out to ctrl-click.
Added such a beast, very incomplete. Setting to 2.4 as reminder for myself, but this bug is not a blocker for the release. 2006-11-03 Michael Natterer <mitch@gimp.org> * app/widgets/Makefile.am * app/widgets/gimpcolorselectorpalette.[ch]: new widget featuring a proof-of-concept palette color selector. It always shows the current palette and doesn't bother to have any features yet. If I don't get around finishing this I will disable it for the 2.4 release, but it's better kept in CVS than on my disk... Addresses bug #132146. * app/widgets/gimpcolordialog.c (gimp_color_dialog_new): attach the passed context to the dialog so the palette selector can find it (puke). * app/gui/gui.c (gui_restore_callback): register the new object with the GType system.
The 'search for a matching color in the palette' behaviour is different than GimpPaletteEditor. Which suggests that the functionality for searching should be moved out to GimpPaletteView. I shall investigate this.
Would be cool if you could factor that code out, I simply duplicated part of it in app/widgets/gimpcolorselectorpalette.c I think it should simply go to app/core/gimppalette, perhaps as: GimpPaletteEntry * gimp_palette_find_color (GimpPalette *palette, GimpRGB *color, GimpPaletteEntry *start_from); or whatever... you will sort it out :-)
Created attachment 78330 [details] [review] Refactor palette searching to gimppalette.c, and synchronize the behaviour of the palette editor and palette based color selector I optimized and simplified the searching code too. I hope this does end up in 2.4 -- it's very useful for copying colors between palettes (disable 'edit active palette' in the palette editor, doubleclick on the destination palette to edit it in the palette editor, single click on the source palette to show it in the palette based color selector, and drag-n-drop colors.)
You forgot to diff the color selector :) And I don't think the new GimpPalette function should accept NULL palettes or colors, such kind of hacks belong into the calling function, please add g_return_val_if_fail (GIMP_IS_PALETTE (palette), NULL); g_return_val_if_fail (color != NULL, NULL); And it will be in 2.4, that's why it's on that milestone.
Created attachment 78336 [details] [review] refactor take 2 .. Okay, done.
That will run into the g_return_if_fail() for NULL palettes or palettes without colors now. And please indent the prototype in the header as all other prototypes in that header.
Created attachment 78338 [details] [review] refactor v3 "That will run into the g_return_if_fail() for NULL palettes or palettes without colors now." Are you saying that's good, bad, or what!? It works for me. "And please indent the prototype in the header as all other prototypes in that header." You don't care about the number of columns taken up? Okay.
No I meant some place has to check for NULL palettes or the code will run into the assertion. See the comitted patch. And yes, we are picky about whitespace ;) 2006-12-14 Michael Natterer <mitch@gimp.org> Applied slightly modified patch from David Gowers which abstracts away and unifies seraching a color in a palette (bug #132146): * app/core/gimppalette.[ch]: added gimp_palette_find_entry(). * app/widgets/gimpcolorselectorpalette.c * app/widgets/gimppaletteeditor.c: use it for selecting matching colors from the active palette.
Is there some way to alter the opposite color from what the color selector is currently editing? In this case, I was thinking of so you could click to set FG then ctrl-click to set BG. I can see that the modifier state is provided so CTRL can be detected, but the color selector API doesn't seem to support that kind of change.
What remains to be done so that this bug report can be closed?
Is one supposed to be able to use an arbitrary palette as the source for the pallete based color palette? If so, is this possible now? If so, how do I switch palettes to use? If not, I suggest we close this bug. (In reply to comment #17) > In this case, I was thinking of so you could click to set FG > then ctrl-click to set BG. Would be nice to have, but that would be a global color selector feature which would require a bit of an effort.
You switch palettes by switching palettes in the palette dialog :) I tried adding a combo box of palettes to that color notebook page, and it looked and felt evil. Also, I don't know what a "global color selector" is, don't we already have the FG/BG color dockable? I'm closing this as FIXED now, any new issues about the palette color selector should go to new bug reports.
(In reply to comment #20) > You switch palettes by switching palettes in the palette dialog :) Oh. I was too focused on the Colormap dialog. > Also, I don't know what a "global color selector" is, don't we already > have the FG/BG color dockable? I meant that no other color selector method in the Color dialog supports Ctrl + Click to set bg color. > I'm closing this as FIXED now /me celebrates 2.4 milestones bugs--
> I meant that no other color selector method in the Color dialog supports Ctrl + > Click to set bg color. That doesn't work in the palette tab of color dialogs either, only in all places that aren't per se editing FG or BG.