After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 132131 - Add mnemonics to Warning dialog
Add mnemonics to Warning dialog
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
1.2.x
Other Linux
: Normal enhancement
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2004-01-21 18:29 UTC by Evert Verhellen
Modified: 2008-07-09 02:31 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Evert Verhellen 2004-01-21 18:29:20 UTC
Add mnemonics to all buttons of the Warning dialog. Currently, only the
Save button has this.

Version: 1.2.5
Comment 1 Jody Goldberg 2004-01-21 20:35:52 UTC
Which warning dialog ?
Comment 2 Evert Verhellen 2004-01-21 21:17:47 UTC
The one that asks `Save changes to workbook '...' before closing?'.
Comment 3 Morten Welinder 2004-01-22 22:24:42 UTC
We could have "_Discard", but what about "Don't quit"?
Comment 4 Evert Verhellen 2004-01-23 17:30:52 UTC
One could use the `n', although it may be interesting to pursue some
level of consistency across GNOME applications. Apparently, AbiWord
and Planner already have the same button labels, and to some extent,
also does gedit. Learning mnemonics will be hard if each GNOME
application has its own set. Maybe having `_Cancel' instead of `Don't
close' seems like a good alternative?
Comment 5 Andreas J. Guelzow 2004-01-24 23:28:35 UTC
Well, we had this dicsussion beofee and found that Cancel wasn't clear
enough: what would you indeed be cancelling?

In any case, the complete version of the dialog has:

Discard all
Discard
Save all
Don't quit / Don't close / Don't logout
Save

as buttons. So even D for Discard is questionable since there are
essentially 2 discard buttons with greatly different result.
Comment 6 Andreas J. Guelzow 2004-01-24 23:30:36 UTC
Oh and from the HIG:

For example Find and Log In are better buttons than than Yes and OK.
Comment 7 Andreas J. Guelzow 2004-01-24 23:35:36 UTC
I am not sure that Abiword is a good example. When one quits Abiword,
you first see a dialog asking "Close all windows and exit?" with a Yes
and a No button. Clicking Yes I would be wondering whether I am given
an option to save my files. I then get that option but have to answer
individually for every file... 
Comment 8 Jody Goldberg 2008-07-09 02:31:37 UTC
The new dialog looks quite different but the complaint still held.  Patched for 1.9.2 and back ported to 1.8.4.