GNOME Bugzilla – Bug 131814
Simplify `Play DVD', `Play VCD' and `Play Audio CD' menu items
Last modified: 2004-12-22 21:47:04 UTC
There are currently 3 `Play' menu items, `Play DVD', `Play VCD' and `Play Audio CD'. Honestly, this is a bit confusing. As there's only one optical device configured in the Preferences dialog, it would be a good idea to figure out automatically what kind of `disc' is loaded and simplify the menu layout, e.g. only list `Play Disc'.
Closing this bug depends on: http://savannah.gnu.org/bugs/?func=detailitem&item_id=8460
libcdio can detect audio CDs, VCDs, SVCDs, but not video DVDs... Another bug created: https://savannah.gnu.org/bugs/index.php?func=detailitem&item_id=9171
Mass reassign.
Fixed in CVS. 2004-10-11 Bastien Nocera <hadess@hadess.net> * src/totem-disc.c: (cd_cache_open_device), (cd_cache_disc_is_vcd), (cd_cache_disc_is_dvd): better error when no medium is found, fix a leak when the subdir can't be opened in the DVD detection, add VCD detection (Closes: #131814) 2004-10-11 Ronald S. Bultje <rbultje@ronald.bitfreak.net> * data/totem.glade: Remove open vcd/cdda/dvd entries, add open disc. * po/POTFILES.in: * src/Makefile.am: Add totem-disc.[ch]. * src/bacon-video-widget-gst.c: (bacon_video_widget_open), (bacon_video_widget_can_play), (bacon_video_widget_get_mrls), (bacon_video_widget_get_metadata_string): Add discid for audio-CDs. Don't open the same media twice. This is sort of a hack for something that I don't quite understand in Totem just yet. * src/bacon-video-widget-xine.c: (bacon_video_widget_can_play), (bacon_video_widget_get_mrls): * src/bacon-video-widget.h: * src/disc-test.c: (main): * src/totem-disc.c: (get_device), (cd_cache_new), (cd_cache_open_device), (cd_cache_open_mountpoint), (cd_cache_free), (cd_cache_disc_is_cdda), (cd_cache_disc_is_vcd), (cd_cache_disc_is_dvd), (cd_detect_type): * src/totem-disc.h: * src/totem.c: (totem_action_open_files_list), (on_play_disc1_activate), (totem_action_remote), (totem_callback_connect): Move MEDIA_* to MEDIA_TYPE_*, add DATA/ERROR, add disc content autodetection for the 'Open Disc' menu entry (VCD still TODO).