This is a very silly menu item and I wish someone would look at this bug, and at
least confirm it.

I completely agree, even weirder is that if you have a nautilus window open and
right click on an empty space between the icons. It's also presented but it is
greyed out. In my opinion it should be removed overthere as well.
Bug #145193 talks about this last part

Created attachment 31058 [details] [review]
Removes Use Default Background from all context menus

How ironicallly my first real contribution to gnome, and it just removes code

I agree that its a bit silly on the desktop context menu, but the patch
removes it everywhere. I'm not sure thats right, since it removes the
only way to get from a folder-specific background to using the gloabl
default folder background.

Created attachment 31158 [details] [review]
Only removes it from the context menu on the desktop

I still think it's better to completely remove it from all context menus, but
here's a patch that just removes it from the desktop menu. 

IMHO the user should just go to Edit Backgrounds & Emblems again to remove the
background again. It's not logical that you can only set it at one place and
reset it on that place and another place. If there should be something in the
context menu then it would be change background, but I guess there is no dialog
with only desktop backgrounds in the code yet, (only the combined one with
emblems I might have a go at that in the future :-)

The last patch looks good. But can't be applied now, as we're in ui/feature and
hard code freeze. It'll go in in the next cycle.

Alexander, it's not true that this context entry is the only way to go from a
folder-specific background to the global default folder background; instead just
drag the "reset" pattern to the folder and it will use the global default folder
background again. Heck, that's even the most discoverable way to do it;-) I
think Backgrounds & Emblems is where people will look to achieve this, since
that's where they set the folder background in the first place.

This context menu entry has bothered me too, so I support its removal. By the
way, if the entry is removed from the context menu in Nautilus also then the
documentation in Help should be changed accordingly, since it currently mentions
the context menu approach to reset it (one sentence needs to be changed).

Based on comment 6, I'm updating the versions and setting the 2.10.0 Gnome
Milestone.  I'm also marking as high priority since it has a patch.

nautilus has branched so I'm removing the BLOCKED_BY_FREEZE keyword.

This can go in now can it not?

In head it's gone from the desktop, still shows in nautilus.

Comment on attachment 31158 [details] [review]
Only removes it from the context menu on the desktop

This, or something like it, has been committed.

Have updated the title and severity to reflect the current situation. Agree that
it should still be nuked from the folder menus as well...

Given that it is gone from the most visible/least-sensical place, I'm taking
this off of the 2.10 showstopper list. Would still be great to get it in, of course.

Luis, what would be needed to get this still in? Should I update the first patch
so it can be applied now that that the 2nd patch has been applied, or should the
maintainers be convinced??

Jaap, I'd start by updating the patch, and then emailing it to
nautilus-list@gnome.org indicating the purpose of the patch and the bug #. That
is usually the best way to get the nautilus maintainer's attention.

Created attachment 36395 [details] [review]
Removes Use Default Background from folder context menu

Updated the patch. Hoping that this will now go in

2005-01-23  Martin Wehner  <martin.wehner@epost.de>

	* src/file-manager/fm-actions.h:
	* src/file-manager/fm-desktop-icon-view.c: (real_merge_menus):
	* src/file-manager/fm-directory-view.c: (real_update_menus):
	* src/file-manager/nautilus-directory-view-ui.xml:
	Remove "Reset Background" entry from folder context menus.
	
	Patch from Jaap Haitsma <jaap@haitsma.org>