After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 131538 - theme-manager freeze
theme-manager freeze
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] theme-manager
git master
Other Linux
: Urgent critical
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
AP1
: 135402 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-01-15 10:44 UTC by david.hawthorne
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (2.23 KB, patch)
2004-03-08 13:18 UTC, padraig.obriain 		none Details | Review

Description david.hawthorne 2004-01-15 10:44:35 UTC 
using gnome-theme-manager from CVS HEAD 14 Jan 2004.

-launch gnome-theme-manager
-press <down> a few times then <up> to cycle through themes

.gnome-theme-manager hung on High Contrast theme(don't know if specific
theme made a difference). I had to pkill gnome-theme-manager to close it.

stack output:

+ Trace 43244

  • #0 g_type_is_a
    at gtype.c line 2774
  • #1 g_signal_emit_valist
    at gsignal.c line 2127
  • #2 g_signal_emit
    at gsignal.c line 2239
  • #3 gnome_window_manager_settings_changed
    at gnome-window-manager.c line 237
  • #4 value_changed
    at metacity-window-manager.c line 69
  • #5 gconf_marshal_VOID__STRING_POINTER
    at gconfmarshal.c line 83
  • #6 g_closure_invoke
    at gclosure.c line 437
  • #7 signal_emit_unlocked_R
    at gsignal.c line 2436
  • #8 g_signal_emit_valist
    at gsignal.c line 2195
  • #9 g_signal_emit
    at gsignal.c line 2239
  • #10 gconf_client_value_changed
    at gconf-client.c line 1874
  • #11 notify_one_entry
    at gconf-client.c line 2381
  • #12 gconf_client_flush_notifies
    at gconf-client.c line 2433
  • #13 notify_idle_callback
    at gconf-client.c line 2327
  • #14 g_idle_dispatch
    at gmain.c line 3273
  • #15 g_main_dispatch
    at gmain.c line 1752
  • #16 g_main_context_dispatch
    at gmain.c line 2300
  • #17 g_main_context_iterate
    at gmain.c line 2381
  • #18 g_main_loop_run
    at gmain.c line 2601
  • #19 gtk_main
    at gtkmain.c line 1169
  • #20 main
    at gnome-theme-manager.c line 1413 






Comment 1


André Dahlqvist





          2004-02-17 16:49:07 UTC
        



I just experienced the same thing: the theme-manager hung when I tried
to scroll down using the scrollbar. This was the very first time I
opened the theme-manager on this clean install (including having wiped
 ~/.gnome* ~/.gconf*, aso), if that helps to narrow it down.






Comment 2


padraig.obriain





          2004-03-08 09:23:51 UTC
        



I have started looking at this. 

What I have seen so far is that gnome_window_manager_settings_changed
is called continuously even before the theme is changed when
gnome-theme-manager is called for the first time by a user. If
gnome-theme-manager is restarted the continuous calling of
gnome-window_manager_setings_changed does not occur.






Comment 3


padraig.obriain





          2004-03-08 09:24:29 UTC
        



*** Bug 135402 has been marked as a duplicate of this bug. ***






Comment 4


padraig.obriain





          2004-03-08 11:23:20 UTC
        



I am increasing the priority as this bug will hit first time users.
I hope to have a patch soon.






Comment 5


padraig.obriain





          2004-03-08 13:18:10 UTC
        



This problem only seems to happen when the user has no Gconf database.

Calling gtk_tree_set_cursor causes gconf_client_set_strinug() to be
called which causes a notification of a change of value which causes
gtk_tree_view_set_cursor to be called even if there is no change in
the cursor value.

My proposed patch checks that the cursor value is changing before
calling gtk_tree_view_set+cursor. Perhaps this problem should be
solved in gconf.






Comment 6


padraig.obriain





          2004-03-08 13:18:52 UTC
        



Created attachment 25333 [details] [review]
Proposed patch






Comment 7


padraig.obriain





          2004-03-11 14:38:55 UTC
        



ICan this patch be reviewed for inclusion in GNOME 2.6.0?






Comment 8


Jody Goldberg





          2004-03-11 19:20:32 UTC
        



It looks safe, but I'm running very low on freeze-violation points at
this point.  Lets save it for cc-2.6.1






Comment 9


bill.haneman





          2004-03-11 22:14:31 UTC
        



Jody: I understand that this bug strikes reproducibly on multiple
systems here; sounds like it would hit any new user account on a 2.6.0
system.  






Comment 10


Vincent Untz





          2004-03-14 14:55:49 UTC
        



Adding BLOCKED_BY_FREEZE keyword.






Comment 11


padraig.obriain





          2004-03-24 17:18:52 UTC
        



Jody,

Can this patch be applied now?






Comment 12


Jody Goldberg





          2004-03-24 17:26:36 UTC
        



Not yet please.  Until the 2.6.0 tarball gets to ftp.gnome.org I'd rather leave
our options open.






Comment 13


padraig.obriain





          2004-04-02 08:08:16 UTC
        



is this patch good to apply now?






Comment 14


Jody Goldberg





          2004-04-02 13:49:40 UTC
        



yes please.






Comment 15


padraig.obriain





          2004-04-02 14:34:20 UTC
        



Patch committed to CVS HEAD.