GNOME Bugzilla – Bug 131322
two feature requests for battstat applet
Last modified: 2004-12-22 21:47:04 UTC
1) It would be nice of battstat could give the remaining time. KDE's applet can do this (it calculates it itself I think). From memory APM gives the remaining time, and you can do a simple division to calculate it in ACPI. 2) It would also be nice if battstat's warning dialog (for when you are running out of power) would disappear when it detected the ACPI event (or whatever is done in APM land) that tells it we went onto AC power. It would also be nice if the dialog was set to always on top and sticky, so that you couldn't miss it. Like with MacOSX, there should still be an option to ok the dialog out of the way.
Part one is a duplicate of #138959 (which while newer, has a patch).
Created attachment 27759 [details] [review] patch for part 2
Cool patch! Do you have commit privaledges Davyd?
Yep, committed.
Kevin, I think this would be ok for 2.6.x also. agree?
Kjartan: I think it's probably safe for 2.6.x.
Applied to stable.
I think there might still be another segfault in this patch caused by a null reference. I haven't tracked it down yet, people will have to help me test.
Created attachment 30093 [details] [review] Patch that sets the warning dialog always on top and sticky The warning dialog is still not set to always on top and sticky as requested by the reporter. I have fixed it in this patch.
That's a cute addition, although something suggests there are HIG considerations with doing this. I'm going to ask a UI-guru first.