After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 131322 - two feature requests for battstat applet
two feature requests for battstat applet
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: battery
2.4.x
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-01-13 11:05 UTC by Danielle Madeley
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
patch for part 2 (2.29 KB, patch)
2004-05-16 14:36 UTC, Danielle Madeley
none Details | Review
Patch that sets the warning dialog always on top and sticky (785 bytes, patch)
2004-07-30 19:04 UTC, Karthik Bharadwaj [Karthik BG]
none Details | Review

Description Danielle Madeley 2004-01-13 11:05:40 UTC
1) It would be nice of battstat could give the remaining time. KDE's applet
can do this (it calculates it itself I think). From memory APM gives the
remaining time, and you can do a simple division to calculate it in ACPI.

2) It would also be nice if battstat's warning dialog (for when you are
running out of power) would disappear when it detected the ACPI event (or
whatever is done in APM land) that tells it we went onto AC power. It would
also be nice if the dialog was set to always on top and sticky, so that you
couldn't miss it. Like with MacOSX, there should still be an option to ok
the dialog out of the way.
Comment 1 Danielle Madeley 2004-05-16 12:02:00 UTC
Part one is a duplicate of #138959 (which while newer, has a patch).
Comment 2 Danielle Madeley 2004-05-16 14:36:21 UTC
Created attachment 27759 [details] [review]
patch for part 2
Comment 3 Kevin Vandersloot 2004-05-16 19:06:24 UTC
Cool patch! Do you have commit privaledges Davyd?
Comment 4 Danielle Madeley 2004-05-17 02:07:22 UTC
Yep, committed.
Comment 5 Kjartan Maraas 2004-05-17 07:42:41 UTC
Kevin, I think this would be ok for 2.6.x also. agree?
Comment 6 Kevin Vandersloot 2004-05-17 12:13:54 UTC
Kjartan: I think it's probably safe for 2.6.x.
Comment 7 Kjartan Maraas 2004-05-20 09:54:21 UTC
Applied to stable.
Comment 8 Danielle Madeley 2004-05-20 17:45:03 UTC
I think there might still be another segfault in this patch caused by a null
reference. I haven't tracked it down yet, people will have to help me test.
Comment 9 Karthik Bharadwaj [Karthik BG] 2004-07-30 19:04:43 UTC
Created attachment 30093 [details] [review]
Patch that sets the warning dialog always on top and sticky

The warning dialog is still not set to always on top and sticky as requested by
the reporter. I have fixed it in this patch.
Comment 10 Danielle Madeley 2004-07-31 02:14:29 UTC
That's a cute addition, although something suggests there are HIG considerations
with doing this. I'm going to ask a UI-guru first.