GNOME Bugzilla – Bug 130509
[PATCH] check also gettext-domain "gdesklets"
Last modified: 2005-08-15 01:47:25 UTC
most sensor-developers are defining a gettext domain but providing there mo-files under gdesklets.mo. as there are many such sensors out there i will suggest that in i18n.py also the domain "gdesklets" will also be checked.
Created attachment 22901 [details] [review] patch: add domain-check for "gdesklets" to i18n.py
Created attachment 22902 [details] [review] corrected patch with removed debugging-print
Adding the PATCH keyword and bumping the priority level to High because of the attached patches.
This looks like a bug in the Makefile in the gdesklets-extras module in CVS where all the translation strings of all sensors in CVS are collected in one .po file with domain gdesklets. This behavior should be fixed. For the time being, your patch provides a good workaround.
in concerns not only gdesklets-extras because i'm a FreeBSD user and the package gdesklets-extras is not ported. until now i didn't know that this module exists. most of the desklets in that module are made as seperate ports. i noticed the problem with the SysInfo desklet. in __init__.py i18n is initalized with that line: global _; _ = i18n.Translator("sysinfo-sensor") but the Sensor installes his language files as gdesklets.mo. for that port iv'e changed the bsd-port-makefile that it installes the mo-files as sysinfo-sensor.mo but it's easier to change i18n.py instead all ported desklets. i guess this will be any longer a common developer mistake. maybe this should also be added to the Sensor Programming Manual at pycage.de.
Franz: They really should use the domain they claim to use. I'll see what I can do. regs, Chris
Thanks for pointing out this issue. It should be fixed in HEAD by some more Makefile tweakage. In addition, RSS now is translatable :). regs, Chris