After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 130473 - "add comment" dialog uses ctime instead of mtime
"add comment" dialog uses ctime instead of mtime
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2004-01-03 22:44 UTC by Graham Cole
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Graham Cole 2004-01-03 22:44:29 UTC
In the add comment dialoge there is an option to add a time/date to the
image comments.  There is an option to add the time from the file creation
date.  Apparently it is getting this information from the file's ctime,
which is not all that useful because it merely contains when the inode was
allocated on that filesystem.

The ctime is not modifiable by any system call.  The only way to change it
is to hack the filesystem itself.  It would probably be much more useful
for this feature to take the mtime of the file.  For example, if I transfer
files from my digital camera to my hard drive that I took 2 months ago,
then use this feature, taking the ctime will add the time that they were
transferred to the hard drive rather than the date the camera placed on the
files.

Using the mtime is probably what most users want since that would contain
the time the picture was actually created, assuming that the date was set
correctly on the digital camera of course.
Comment 1 Alexander Kirillov 2004-01-22 23:31:25 UTC
Indeed, this dialog does use ctime. I agree with the reporter that
mtime is probably better. Also: the status line under image preview
shows image mtime, so this may be different from "image creation time"
(aka ctime) used in the comment and confusing the user. 
Comment 2 Alexander Kirillov 2004-01-23 15:15:44 UTC
Changing summary to be more descriptive
Comment 3 Alexander Kirillov 2004-01-23 22:26:09 UTC
BTW, it is trivial to fix: all it takes is changing in the file
gthumb/ src/ dlg-comment.c the line 
t = get_file_ctime (filename);
to 
t = get_file_mtime (filename);

Comment 4 Paolo Bacchilega 2004-01-24 14:51:41 UTC
Fixed in CVS.