After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 130220 - Check for missing elements and attributes in html.lang syntax file
Check for missing elements and attributes in html.lang syntax file
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
0.7.x
Other All
: Low trivial
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2003-12-30 13:33 UTC by Bart Vanhaute
Modified: 2006-07-26 09:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add missing keywords (2.35 KB, patch)
2003-12-30 15:30 UTC, Paolo Borelli
committed Details | Review

Description Bart Vanhaute 2003-12-30 13:33:40 UTC
While editing a html page through gedit, I saw the IMG element was not
being highlighted. That tag was indeed missing from the list of entities in
/usr/share/gtksourceview-1.0/language-specs/html.lang. 

So I decided to do a quick study of other missing items, according to the
HTML 4.01 STRICT DTD (there is also a transitional, but i didn't check
that). This was my result.

missing ELEMENTS:
DEL
H1
H2
H3
H4
H5
H6
IMG
INS

missing ATTRIBUTES (some are rather obsure or just reserved for future use):
checked
datafld
dataformatas
datapagesize
datasrc
declare
defer
disabled
event
multiple
nohref
ondblclick
readonly
selected
Comment 1 Paolo Borelli 2003-12-30 15:28:58 UTC
Here it is a patch to add them. Note that h1 etc were already working
and that I didn't include data* since they were not mentioned in
http://www.w3.org/TR/html401/index/attributes.html
I also added a couple more that I noticed in that doc, but I've not
gone through the full list to see if other are missing.
Comment 2 Paolo Borelli 2003-12-30 15:30:02 UTC
Created attachment 22767 [details] [review]
add missing keywords
Comment 3 Paolo Maggi 2003-12-30 15:58:33 UTC
Bart: are the data* attributes commonly used? Why did you say h1, etc
are not working?

Paolo: please, commit the patch with a ChangeLog entry.

I'm going to change the summory of the bug report to "Check for
missing elements and attributes in html.lang syntax file" instead of
closing it.

This is for remembering to check for missing elements and attributes
against the HTML standard.

Adding "easy-fix" keyword.

Paolo: please, remove the "PATCH" keyword when you will have committed
  the patch.
Comment 4 Paolo Borelli 2003-12-30 16:25:26 UTC
committed above patch, removed PATCH keyword.
Comment 5 Bart Vanhaute 2004-01-02 19:20:55 UTC
The reason I reported h* elements as not working is because of the way
I was searching for missing elements and attributes : I just did a
grep for all html defined elements and attributes to see if they where
listed in the html.lang file. Thus, h1, h2, ... and h6 were not found
because they are present in a "abbreviated" form. I should have double
checked... sorry.

The data* attributes are reserved for future use (see
http://www.w3.org/TR/html4/sgml/dtd.html). I leave it at your
discretion whether these belong there or not.
Comment 6 Paolo Maggi 2006-07-26 09:25:27 UTC
No activity on this bug.
Closing