After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 130172 - Text Function When Opening Excel File
Text Function When Opening Excel File
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Main System
1.2.x
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2003-12-29 15:29 UTC by mike
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.1/2.2

Attachments
Adjust string args to not do implicit conversion to int(0) (1.45 KB, patch)
2004-01-09 03:33 UTC, Jody Goldberg 		none Details | Review

Description mike 2003-12-29 15:29:51 UTC 
When opening, and recalculating, an excel or OOCalc spreadsheet which has a
text formula as '=text(A1,0)', for example, Gnumeric doesn't recognise the
format and the formula needs to be changed to '=text(A1,"0")' (double
quotes around the format).

Gnumeric seems to only accept the format text part of the function in
double quotes. Excel and OOCalc both accept formats as 0 (without
quotes) as well. They both also treat 0.00 as 0 in the format.

I have tested this on Gnumeric version 1.2.2.

To display 2 decimal places in excel and OOCalc, the format part needs
to be in double quotes eg '=text(A1,"0.00")' in which case the file
opens ok in Gnumeric.

Thanks
Comment 1 Morten Welinder 2003-12-30 18:48:57 UTC 
We're explicitly checking for a string second arg.  I guess we can just
drop the test.
Comment 2 Jody Goldberg 2004-01-09 03:32:25 UTC 
Thank you
This was a fantastic bug
It pointed out a whole class of errors.  The patch itself was pretty
trivial, but the the larger issue is fairly low level and changes the
implict conversions we perform on arguments.  I'll attach the patch
here, but don't want to apply it to the stable branch just yet.  Let
me test it for a while more.  Things look good on our unit tests, but
I'd like to see one release in the wild before backporting.  Please
remind me in one month.
Comment 3 Jody Goldberg 2004-01-09 03:33:38 UTC 
Created attachment 23135 [details] [review]
Adjust string args to not do implicit conversion to int(0)
Comment 4 Jody Goldberg 2004-04-02 14:09:09 UTC 
Patch is in 1.3.0 but I've decided not to backport.  It's just too central.