After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 129924 - Source tree contains old icon themes, causing extra strings
Source tree contains old icon themes, causing extra strings
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] Backgrounds Emblems and Themes
0.x.x [obsolete]
Other Linux
: High normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-12-23 22:46 UTC by Åsmund Skjæveland
Modified: 2005-05-22 13:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (16.37 KB, patch)
2005-03-16 19:35 UTC, Diego González
committed Details | Review

Description Åsmund Skjæveland 2003-12-23 22:46:19 UTC
The directory icons/ contains various icon themes, which were used in GNOME
1.4, but are apparently not used anymore. The XML files in this component
contain strings that are marked translatable, but which apparently aren't
used anywhere, to the agony of translators.

Solution (as far as I can tell): Remove icons/ from source tree.
Comment 1 Christian Neumair 2003-12-25 13:25:02 UTC
You are totally right. I'd really like to remove this old cruft, not
only the few strings. Maybe we should even completely remove this
outdated theming crap lurking around in the source dir. Let's see what
Alex says when he's back from holiday.

regs,
 Chris
Comment 2 Diego González 2005-03-16 19:35:06 UTC
I just went ahead and removed all of the traces of the old theme system, here is
the patch. I'm running with the patch and everything seems ok. May i commit it?
Comment 3 Diego González 2005-03-16 19:35:44 UTC
Created attachment 38801 [details] [review]
Patch
Comment 4 Diego González 2005-04-04 19:33:16 UTC
This bug should be closed as I have just killed the support for gnome 1.x themes.
Comment 5 Martin Wehner 2005-05-14 17:32:47 UTC
Comment on attachment 38801 [details] [review]
Patch

Marking committed. We still need to remove the theme files from cvs to close
the bug though.
Comment 6 Sebastien Bacher 2005-05-22 13:24:49 UTC
any reason to not remove nautilus-theme.[ch] and close the bug?
Comment 7 Martin Wehner 2005-05-22 13:35:05 UTC
It's done on HEAD, closing.