After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 129855 - Patch for a massive X resource leak
Patch for a massive X resource leak
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: panel
2.4.x
Other Linux
: High major
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-12-22 18:25 UTC by Kristian Rietveld
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch. (757 bytes, patch)
2003-12-22 18:25 UTC, Kristian Rietveld 		none Details | Review

Description Kristian Rietveld 2003-12-22 18:25:08 UTC 
I recently discovered that my X process' memory usage was about ~2 gigs
after ~10 days of usage. So something just had to leak resources ;). Using
xrestop I discovered that gnome-panel was the leaking process.

Today, I spent a few hours trying to track this leak down; the attached
patch seems to fix it for me. gnome-panel's resource usage now stays steady
at about 2 megs here, instead of continously growing :).

Upped the severity to major; since I find this a pretty cricital leak.
Comment 1 Kristian Rietveld 2003-12-22 18:25:46 UTC 
Created attachment 22649 [details] [review]
patch.
Comment 2 Mark McLoughlin 2003-12-29 14:37:00 UTC 
Ouch. Thanks Kris. Looks good for gnome-2-4 and HEAD branches.
Comment 3 Luis Villa 2003-12-30 00:14:52 UTC 
I don't figure Kris will forget this, but just in case adding keywords.
Comment 4 Mark McLoughlin 2004-01-27 15:29:13 UTC 
Committed to HEAD:

2004-01-27  Mark McLoughlin  <mark@skynet.ie>
                                                                     
                                                                         
        Fix for bug #129855 from Kristian Rietveld.
                                                                     
                                                                         
        * panel-background.c: (free_prepared_resources):
        Free background pixmap when we have a translucent
        colour background.
Comment 5 Kjartan Maraas 2004-01-29 12:59:13 UTC 
Any reason not to commit this to gnome-2-4?
Comment 6 Mark McLoughlin 2004-01-29 15:36:03 UTC 
Because I'm not expecting to do another 2.4 release ...