Created attachment 22534 [details] [review]
Patch to make gstreamer core compile on OS X

Created attachment 22554 [details] [review]
patch to make the gstreamer plugins compile on os x

Thank you for the patches!

Sorry to cause you anymore trouble, but it seems that there are some
problems encountered in make files. The first patch, for gstreamer,
fails in gst/parse/Makefile.am. Your second patch, for gst-plugins,
fails in gst/playondemand/Makefile.am.

Could you please update to CVS revision HEAD and try to rectify the
problems?

Upgrading the priority to High because patches are attached.

Hi,

the mplex and png bits have already been fixed in other commits. The
avi/riff stuff isn't right. Note that on Linux, sizeof() provides an
unsigned integer. I'm not sure why it provides an unsigned long
integer on OS X/Panther. Removing libgstplayondemand.la from LDADD
isn't really right since the binary depends on it. What kind of errors
are you getting here? The RTP thing looks ok to me, I'll commit that too.

As for the core: I think Dave'd better look at that than me.

On second thought, gstplayondemand is a suport lib, not a link lib, so
the patch was correct, sorry. It's been fixed in CVS already, however. ;).

The only remaining issue now (for plugins) is the avi/riff sizeof() stuff.

If you don't mind requiring glibc 2.1+, we can solve the sizeof()
problem by using the %zu format string instead of %lu.

We don't depend on glibc. GStreamer needs to build with other libcs.
Though it's ok to special case it.

The correct fix in this case it to use (gint) sizeof (...) as the
argument in the debug message though.

The z length modifier is C99.

I personally have no objections against C99'isms (we require it for
vararg macros already). Don't know what others think? Glib uses casts
to gsize for some sizeof() calls. Others are simply called as is. Do
we follow glib or do we use C99?

Dave, Benjamin, please comment?

We still are trying to avoid c99-isms.

So what do we do... Casts?

Bleh...

Yep, casts.

I merged the rest of these patches.  If there are any more build
problems, please create a new bug.