After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 128852 - Gdk cursors don't look good on win32
Gdk cursors don't look good on win32
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
2.2.x
Other Windows
: Normal normal
: Small fix
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2003-12-08 23:18 UTC by Tim Evans
Modified: 2007-04-26 05:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch against gtk+-2.2.4 (26.03 KB, patch)
2003-12-08 23:18 UTC, Tim Evans 		none Details | Review

Description Tim Evans 2003-12-08 23:18:00 UTC 
I will attach a patch that causes gdk_cursor_new to use the builtin win32
cursors where there is a good win32 equivalent for the X cursor.

I don't think that my patch is a very good solution for this bug, but it's
easy to do right now.  The ideal solution may depend on bug #69436 being
done first.
Comment 1 Tim Evans 2003-12-08 23:18:28 UTC 
Created attachment 22235 [details] [review]
Patch against gtk+-2.2.4
Comment 2 Tor Lillqvist 2004-03-01 21:00:14 UTC 
Can a theme engine replace cursors? If so, it probably makes more 
sense to just rely on people using the gtk-wimp theme engine if they 
want a more Windows-like appearance.
Comment 3 Tim Evans 2004-03-01 21:17:42 UTC 
As far as I can tell, no.  Cursor theming is what bug #69436 is
talking about, and it hasn't been implemented yet.  My patch is just a
hack that works right now.
Comment 4 Dominic Lachowicz 2006-03-28 03:39:40 UTC 
It would be nice to get this into Gdk (minus the g_print). It seems pretty natural to map these directly back onto the Win32 builtin cursors when available. The theme engine shouldn't have to worry about remapping cursors.
Comment 5 Matthias Clasen 2006-03-28 03:42:39 UTC 
Makes sense to me. Tor, what do you think ?
Comment 6 Tor Lillqvist 2006-03-28 07:34:38 UTC 
Will an application look odd if some cursors are the builtin ones and others are the X11 ones? Maybe not a big deal. I'll check what it looks like and apply the patch unless it looks really horrible... Or maybe it should be user-overridable through .gtkrc?
Comment 7 Cody Russell 2007-04-26 05:37:44 UTC 
Committed to trunk and gtk-2-10.

I did change two of the arrows, though.  I set "sb_h_double_arrow" to IDC_SIZEWE and "sb_v_double_arrow" to IDC_SIZENS (they were set to NULL in Tim's patch).  I did this because paned widgets use these Gdk cursors and these two look much better than what was being used by default.