After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 128381 - add a "lock screen" button to typing lock screen
add a "lock screen" button to typing lock screen
Status: RESOLVED FIXED
Product: DrWright
Classification: Other
Component: general
unspecified
Other Linux
: High critical
: ---
Assigned To: drwright-maint
drwright-maint
: 322111 339118 346461 361915 527106 594121 598146 609103 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-12-02 17:49 UTC by Thomas Vander Stichele
Modified: 2011-12-11 12:55 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
add a lock button (6.00 KB, patch)
2008-03-30 20:53 UTC, Matthias Clasen
needs-work Details | Review
Add Lock button to break window (13.62 KB, patch)
2011-04-16 22:41 UTC, Christian Persch
none Details | Review

Description Thomas Vander Stichele 2003-12-02 17:49:24 UTC
Drwright brings back the screen at the end of countdown during the lockout.
 For security reasons it would be a good idea to have an option to lock the
desktop completely during the break, so you can safely walk away and trust
the machine not to be tampered with after the end of the pause.
Comment 1 Luis Villa 2004-01-03 22:17:38 UTC
That would be nice. Updated the subject a bit to make it more clear, 
at least to me, but I'm not 100% sure it is actually still clear :)
Comment 2 Robert McMeekin 2004-02-23 07:23:15 UTC
How about the fact that you can [alt]-[tab] between windows during the
break and still type in them?
Comment 3 Richard Hult 2004-02-24 08:57:16 UTC
No you can't (in 2.5.x).
Comment 4 Thomas Vander Stichele 2004-12-21 14:57:49 UTC
richard, what do you think about the original request ?
Comment 5 Richard Hult 2004-12-21 15:04:05 UTC
Adding a button to the break screen for locking the screen would be pretty nice.
Comment 6 Richard Hult 2005-11-27 10:11:47 UTC
*** Bug 322111 has been marked as a duplicate of this bug. ***
Comment 7 Vincent Untz 2006-07-25 13:54:38 UTC
*** Bug 346461 has been marked as a duplicate of this bug. ***
Comment 8 Richard Hult 2006-10-13 12:13:40 UTC
*** Bug 361915 has been marked as a duplicate of this bug. ***
Comment 9 Jens Granseuer 2007-02-04 20:41:06 UTC
*** Bug 339118 has been marked as a duplicate of this bug. ***
Comment 10 Matthias Clasen 2008-03-29 04:36:25 UTC
Add a Lock button would also help with the fact that it is not safe at all to leave the machine during the break if the "Postpone" button is present, because it allows anybody to access the machine.

This has been brought up in Fedora: 
https://bugzilla.redhat.com/show_bug.cgi?id=152042
Comment 11 Richard Hult 2008-03-29 07:25:06 UTC
The typing monitor is not supposed to be considered safe in any way, postpone enabled or not... it even shows what's on the screen during breaks.

It should be quite easy to add a lock button if someone wants to do it.

Comment 12 Matthias Clasen 2008-03-30 20:53:15 UTC
Created attachment 108288 [details] [review]
add a lock button
Comment 13 Jens Granseuer 2008-03-30 22:21:30 UTC
I'd switch the button order, and IMO the Lock button shouldn't get focus by default.
Comment 14 Jens Granseuer 2008-03-31 15:53:52 UTC
And of course it means if you return from the screensaver before the break is up, we don't have the grab anymore, so you can e.g. bring up the alt-tab-menu...
Comment 15 Matthias Clasen 2008-03-31 16:02:03 UTC
I know. I just felt it was better than just nuking the break window altogether...
Comment 16 Jens Granseuer 2008-04-09 16:22:11 UTC
*** Bug 527106 has been marked as a duplicate of this bug. ***
Comment 17 Matthias Clasen 2008-08-16 21:44:00 UTC
Should probably use dbus to talk to gnome-screensaver instead of gnome-screensaver-command. Then we can also notice when the lock goes away and regrab the keyboard.
Comment 18 Matt Kraai 2009-01-28 00:06:46 UTC
(In reply to comment #12)
> Created an attachment (id=108288) [edit]
> add a lock button

This patch appears to erroneously (but harmlessly) duplicate the

 	signals[DONE] =

line.
Comment 19 Piotr Czachur 2009-06-02 09:52:22 UTC
Guys, this bug has 6 years, why is it take such a long time?

I must say that it is very important feature, because most users leave the computer during typing break (thats the purpose of typing break, isn't it?). So it's natural consequence that they want the screen to be locked with password when they come back to work.
Comment 20 jean 2009-09-04 09:17:14 UTC
Agreed with Piotr...

Should be more than necessary for security reasons.
Comment 21 Jens Granseuer 2009-09-04 11:15:41 UTC
*** Bug 594121 has been marked as a duplicate of this bug. ***
Comment 22 unique user 2009-10-13 10:59:03 UTC
Not to be a spoilsport, but, if someone needs this feature, like me, there is an alternative: "workrave"

http://www.workrave.org/welcome/
Comment 23 Jens Granseuer 2009-10-26 20:53:37 UTC
*** Bug 598146 has been marked as a duplicate of this bug. ***
Comment 24 Jens Granseuer 2010-02-06 10:49:57 UTC
*** Bug 609103 has been marked as a duplicate of this bug. ***
Comment 25 Jack Leigh 2010-04-22 15:57:54 UTC
Yes please!
Comment 26 Bastien Nocera 2010-11-21 00:10:52 UTC
Mass move to DrWright module. The code has been removed from the control-center, and put back in the drwright module as its interaction with the GNOME 3.x experience was not defined.

See http://git.gnome.org/browse/drwright
Comment 27 Christian Persch 2011-04-16 22:41:14 UTC
Created attachment 186115 [details] [review]
Add Lock button to break window

Based on a patch by Matthias Clasen.

Bug #128381.
Comment 28 Christian Persch 2011-12-11 12:55:54 UTC
Fixed on master.