GNOME Bugzilla – Bug 128109
Add "Clear" button to reset the search entry
Last modified: 2006-06-02 02:09:20 UTC
Search field should have a Clear button after it (like in Evolution) so that you could easily reset the view to non-filtered once you have found what you looked for.
We already discussed this on the ML (see: http://lists.gnome.org/archives/rhythmbox-devel/2003-November/msg00189.html) It was agreed that we should add an entry in the View menu saying "View All" which would reset the filters and the search entry.
*** Bug 135553 has been marked as a duplicate of this bug. ***
*** Bug 131151 has been marked as a duplicate of this bug. ***
*** Bug 138952 has been marked as a duplicate of this bug. ***
*** Bug 139892 has been marked as a duplicate of this bug. ***
Created attachment 27314 [details] [review] rb-view-all-menu-item.patch Patch, as discussed. I'm not sure which kbd shortcut we should use. Furthermore, the search stuff is incredibly twisted, and I didn't manage to make the "View All" menu unsensitive when the "search" field is empty. Hopefully you will ;)
Ok, I'm going to put this patch off for a bit, as I have a branch which is converted to use GtkAction. Once I merge that let's have a look at the patch.
Finally got a chance to look this over and port it to the new GtkAction bits. I also added a keybinding at the same time. I chose "Ctrl+Y", because very little remains free :/ If you think of something better let me know... Anyways, * committed rhythmbox-devel@gnome.org--2004/rhythmbox--main--0.9--patch-9 Thanks Bastien!
*** Bug 319892 has been marked as a duplicate of this bug. ***
*** Bug 319893 has been marked as a duplicate of this bug. ***
*** Bug 319902 has been marked as a duplicate of this bug. ***
*** Bug 326423 has been marked as a duplicate of this bug. ***
*** Bug 335174 has been marked as a duplicate of this bug. ***
Given new interface and discussion on the mailing list, see: http://mail.gnome.org/archives/rhythmbox-devel/2006-March/msg00035.html I propose that this bug should be re-opened (/me ducks) since it is clearly a highly requested feature that could be implemented fairly unobtrusively, see also: http://mail.gnome.org/archives/rhythmbox-devel/2006-March/msg00056.html
Created attachment 61584 [details] [review] Uploaded patch provided by James "Doc" Livingston on the ML Patch by "Doc" from here: http://mail.gnome.org/archives/rhythmbox-devel/2006-March/binS5UIeMVHfB.bin linked from this post: http://mail.gnome.org/archives/rhythmbox-devel/2006-March/msg00056.html Tested this patch on FC-4 with libsexy-devel package from Fedora Extras and it works well.
Re-opening bug after discussing it with James Livingston on IRC.
Retitling summary.
Created attachment 62582 [details] [review] updated patch This patch allows building against a system-wide copy of libsexy, but will use an internal copy if it can't be found or --with-internal-libsexy is found.
(In reply to comment #18) > Created an attachment (id=62582) [edit] > updated patch > > This patch allows building against a system-wide copy of libsexy, but will use > an internal copy if it can't be found or --with-internal-libsexy is found. Patch works for me.
Committed to cvs.
(In reply to comment #8) > Finally got a chance to look this over and port it to the new GtkAction bits. I > also added a keybinding at the same time. I chose "Ctrl+Y", because very little > remains free :/ If you think of something better let me know... Looks like this thread is going in a different direction, but FWIW I think Ctrl+Shift+Backspace would be good (in addition to Ctrl+Y?) since it is easy to remember (for me) as akin to GTK+'s Ctrl+Backspace.
*** Bug 342128 has been marked as a duplicate of this bug. ***
*** Bug 343658 has been marked as a duplicate of this bug. ***