After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 127951 - plugins aren't finding X headers adn build outside srcdir
plugins aren't finding X headers adn build outside srcdir
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal normal
: 0.7.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-11-26 06:08 UTC by Mike Castle
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Mike Castle 2003-11-26 06:08:54 UTC
I need the following patch to accomplish two goals:
1) Build outside of the source tree (that's the one dealing with the .pc file)
2) Build several plugins that aren't finding the X headers

Now, obviously this is not a correct source patch, since I'm mucking about
with the Makefile.in instead of Makefile.am.  However, I hope that it
points in the right direction.

The problem is probably that I don't have /usr/include/X11 (ie, a symlink
to /usr/X11R6/include).

Anyway, I suspect that adding something like:
INCLUDES = $(X_CFLAGS)
to the appropriate Makefile.am would solve the issues, but I've
unfortunately no time to verify.

diff -ru gst-plugins-0.7.2.orig/ext/sdl/Makefile.in
gst-plugins-0.7.2/ext/sdl/Makefile.in
--- gst-plugins-0.7.2.orig/ext/sdl/Makefile.in  2003-11-23
13:20:37.000000000 -0800
+++ gst-plugins-0.7.2/ext/sdl/Makefile.in       2003-11-25
15:51:25.000000000 -0800
@@ -481,7 +481,7 @@
 am_libgstsdlvideosink_la_OBJECTS = libgstsdlvideosink_la-sdlvideosink.lo
 libgstsdlvideosink_la_OBJECTS = $(am_libgstsdlvideosink_la_OBJECTS)
 
-DEFAULT_INCLUDES =  -I. -I$(srcdir) -I$(top_builddir)
+DEFAULT_INCLUDES =  -I. -I$(srcdir) -I$(top_builddir) $(X_CFLAGS)
 depcomp = $(SHELL) $(top_srcdir)/depcomp
 am__depfiles_maybe = depfiles
 @AMDEP_TRUE@DEP_FILES = \
diff -ru gst-plugins-0.7.2.orig/gst-libs/gst/xoverlay/Makefile.in
gst-plugins-0.7.2/gst-libs/gst/xoverlay/Makefile.in
--- gst-plugins-0.7.2.orig/gst-libs/gst/xoverlay/Makefile.in    2003-11-23
13:20:54.000000000 -0800
+++ gst-plugins-0.7.2/gst-libs/gst/xoverlay/Makefile.in 2003-11-25
15:51:25.000000000 -0800
@@ -480,7 +480,7 @@
 am_libgstxoverlay_la_OBJECTS = libgstxoverlay_la-xoverlay.lo
 libgstxoverlay_la_OBJECTS = $(am_libgstxoverlay_la_OBJECTS)
 
-DEFAULT_INCLUDES =  -I. -I$(srcdir) -I$(top_builddir)
+DEFAULT_INCLUDES =  -I. -I$(srcdir) -I$(top_builddir) $(X_CFLAGS)
 depcomp = $(SHELL) $(top_srcdir)/depcomp
 am__depfiles_maybe = depfiles
 @AMDEP_TRUE@DEP_FILES = ./$(DEPDIR)/libgstxoverlay_la-xoverlay.Plo
diff -ru gst-plugins-0.7.2.orig/pkgconfig/Makefile.in
gst-plugins-0.7.2/pkgconfig/Makefile.in
--- gst-plugins-0.7.2.orig/pkgconfig/Makefile.in        2003-11-23
13:21:28.000000000 -0800
+++ gst-plugins-0.7.2/pkgconfig/Makefile.in     2003-11-25
18:38:31.000000000 -0800
@@ -691,7 +691,7 @@
 
 ### how to generate pc files from base .pc file in other dir
 $(pcfiles_gconf): gstreamer-gconf-@GST_MAJORMINOR@%.pc: \
-       $(srcdir)/../gst-libs/gst/gconf/gstreamer-gconf%.pc
+       ../gst-libs/gst/gconf/gstreamer-gconf%.pc
        cp $< $@
 # Tell versions [3.59,3.63) of GNU make to not export all variables.
 # Otherwise a system limit (for SysV at least) may be exceeded.
diff -ru gst-plugins-0.7.2.orig/sys/v4l/Makefile.in
gst-plugins-0.7.2/sys/v4l/Makefile.in
--- gst-plugins-0.7.2.orig/sys/v4l/Makefile.in  2003-11-23
13:21:32.000000000 -0800
+++ gst-plugins-0.7.2/sys/v4l/Makefile.in       2003-11-25
15:51:26.000000000 -0800
@@ -509,7 +509,7 @@
        libgstvideo4linux_la-gstv4lcolorbalance.lo
 libgstvideo4linux_la_OBJECTS = $(am_libgstvideo4linux_la_OBJECTS)
 
-DEFAULT_INCLUDES =  -I. -I$(srcdir) -I$(top_builddir)
+DEFAULT_INCLUDES =  -I. -I$(srcdir) -I$(top_builddir) $(X_CFLAGS)
 depcomp = $(SHELL) $(top_srcdir)/depcomp
 am__depfiles_maybe = depfiles
 @AMDEP_TRUE@DEP_FILES = ./$(DEPDIR)/libgstvideo4linux_la-gstv4l.Plo \
Comment 1 Stephane Loeuillet 2004-01-02 22:18:58 UTC
also got this one with 0.7.3

seems it was fixed in current CVS HEAD (2004-01-02)

please try CVS or wait for 0.7.4
Comment 2 Ronald Bultje 2004-01-02 23:25:08 UTC
Yes, Thomas fixed this. Closing.