After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 127636 - [patch] output format options are hard coded
[patch] output format options are hard coded
Status: RESOLVED NOTABUG
Product: sound-juicer
Classification: Applications
Component: general
0.5.7
Other Linux
: Normal normal
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-11-21 22:02 UTC by Brent Fox
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch to desensitize widgets for encodings that are not installed (1.93 KB, patch)
2003-11-21 22:03 UTC, Brent Fox
none Details | Review

Description Brent Fox 2003-11-21 22:02:40 UTC
As filed in Red Hat Bugzilla:
http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=108405

The "Output Format" widgets (Ogg Vorbis, FLAC, MP3 and Wave) are hard
coded, so that they appear as valid choices even if those gstreamer plugins
are not installed.  Both FLAC and MP3 plugins are in the
gstreamer-plugin-extras packages which does not ship with Fedora.

I'm attaching a proposed patch that queries gstreamer to see if the plugins
are installed.  If they are not, the widgets are then disabled.

On a related subject, the "Output Format" options may be better presented
in a GtkOptionMenu instead of a 2x2 grid of GtkRadioButtons.  It would more
closely match the "Directory Hierarchy" and "File Name" GtkOptionMenu
widgets if it were an OptionMenu.
Comment 1 Brent Fox 2003-11-21 22:03:52 UTC
Created attachment 21688 [details] [review]
proposed patch to desensitize widgets for encodings that are not installed
Comment 2 Brent Fox 2003-12-05 21:05:46 UTC
ping?
Comment 3 Bastien Nocera 2003-12-05 21:08:33 UTC
I already fixed that a long time ago, I believe.
Did you re-run gst-register after installing the new plugin?
Comment 4 Brent Fox 2003-12-05 22:49:07 UTC
Bastien: All I can tell is that sound-juicer out of CVS has all
encoding options sensitized even though I don't have
gstreamer-plugins-extras installed.
Comment 5 Brent Fox 2003-12-11 22:36:02 UTC
I must have been doing something wrong...s-j out of cvs does the
detection correctly without needing my patch.  Looks like Bastien
added that code on Sept. 1.  

Anyway, sorry for the fuss.  Closing this report now.